From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Ben Greear <greearb@candelatech.com>,
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Re: [PATCH] mac80211: prevent skb/txq mismatch
Date: Fri, 13 Jan 2017 11:13:10 +0100 [thread overview]
Message-ID: <1484302390.27366.0.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQnA4X+OPC2eFQO9tj+a+-z=_FTKA6UR_uJAUrQvzjZZ8Q@mail.gmail.com> (sfid-20170113_100443_344461_0D63BB30)
> > What I don't understand - and you haven't really described - is how
> > the changes fix it? Could you resend with a paragraph added that
> > explains that?
>
> "Since downgrading unicast traffic to vif->txq must not be done
> there's no txq to put a frame on if sta->uploaded is false. Therefore
> the code is made to fall back to regular tx() op path if the
> described condition is hit. " -- is this sufficient?
Makes sense.
> > Also, you're adding a test:
> >
> > > if (sta && !sta->uploaded)
> >
> > but couldn't do move that into the existing "if (sta)" block?
> > Everything before that only ever returns NULL anyway.
>
> Good point. It makes more sense to put the sta->uploaded check in if
> (sta) block. I'll move it.
>
Ok, thanks.
johannes
next prev parent reply other threads:[~2017-01-13 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 14:28 [PATCH] mac80211: prevent skb/txq mismatch Michal Kazior
2017-01-12 14:45 ` Mohammed Shafi Shajakhan
2017-01-12 14:51 ` Johannes Berg
2017-01-12 14:54 ` Mohammed Shafi Shajakhan
2017-01-12 18:11 ` Felix Fietkau
2017-01-12 19:05 ` Dave Taht
2017-01-13 8:16 ` Johannes Berg
2017-01-13 9:04 ` Michal Kazior
2017-01-13 10:13 ` Johannes Berg [this message]
2017-01-13 12:32 ` [PATCH v2] " Michal Kazior
2017-01-13 13:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484302390.27366.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.