All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Juro Bystricky <juro.bystricky@intel.com>,
	bitbake-devel@lists.openembedded.org
Cc: jurobystricky@hotmail.com
Subject: Re: [PATCH] cookerdata.py: check for existence of configuration files
Date: Fri, 13 Jan 2017 10:54:42 +0000	[thread overview]
Message-ID: <1484304882.4367.252.camel@linuxfoundation.org> (raw)
In-Reply-To: <1484264431-28529-1-git-send-email-juro.bystricky@intel.com>

On Thu, 2017-01-12 at 15:40 -0800, Juro Bystricky wrote:
> Presently there is no check to verify the existence of configuration
> files as listed in BBMULTICONFIG. For example, BBMULTICONFIG =
> "foobar" in local.conf
> does not trigger an error when there is no
> conf/multiconfig/foobar.conf.
> The missing file is silently ignored.
> 
> This patch verifies the existence of config files and errors-out with
> the message:
> 
> ERROR: BBMULTICONFIG="foobar" but the configuration file
> './conf/multiconfig/foobar.conf' does not exist!
> 
> when the file does not exist.
> 
> [YOCTO#10917]

Sorry but we can't do this. One reason for some of the recent changes
was to move the handling of this to the metadata and out of bitbake.
We've therefore now got:

include conf/multiconfig/${BB_CURRENT_MC}.conf

in bitbake.conf and the system looks for the file that way. The user is
free to add other files in other paths and bitbake doesn't know/care
about the directory layout.

If we really want to make this error, we'd need to add an empty
conf/multiconfig/default.conf and then change this to a require instead
of an include. Bitbake's standard error messages would then kick in.

Cheers,

Richard


  reply	other threads:[~2017-01-13 10:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 23:40 [PATCH] cookerdata.py: check for existence of configuration files Juro Bystricky
2017-01-13 10:54 ` Richard Purdie [this message]
2017-01-13 17:01   ` Bystricky, Juro
2017-01-13 17:06     ` Richard Purdie
2017-01-13 17:08       ` Bystricky, Juro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484304882.4367.252.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=juro.bystricky@intel.com \
    --cc=jurobystricky@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.