All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Christoph Anton Mitterer <calestyo@scientia.net>
Cc: <linux-block@vger.kernel.org>, <nbd-general@lists.sourceforge.net>
Subject: Re: NBD: exported files over something around 1 TiB get an insane device size on the client side and are actually empty
Date: Sat, 14 Jan 2017 20:03:48 -0500	[thread overview]
Message-ID: <1484442228.7132.0@smtp.office365.com> (raw)
In-Reply-To: <1484436698.7110.29.camel@scientia.net>

On Sat, Jan 14, 2017 at 6:31 PM, Christoph Anton Mitterer 
<calestyo@scientia.net> wrote:
> Hi.
> 
> On advice from Alex Bligh I'd like to ping linux-block and nbd-general
> about the issue described here:
> https://github.com/NetworkBlockDevice/nbd/issues/44
> 
> What basically happens is, that with a recent kernel (Linux heisenberg
> 4.9.0-1-amd64 #1 SMP Debian 4.9.2-2 (2017-01-12) x86_64 GNU/Linux),
> when a device larger than something between 1 TiB and 2 TiB is 
> exported
> via nbd-server and connected to via nbd-client (which uses the kernel
> driver, AFAIU) than the device size gets insanely large while reading
> from /dev/nbd0 gives actually nothing.
> 
> 
> The bug does not seem to happen when the kernel is not involved (we
> tried using nbd-server and qemu-img as the client).
> 
> Don't think it makes all too much sense to copy & paste everything 
> from
> what was tried already for testing here, so please have a look at the
> issue on github.

Yeah I noticed this in testing, there's a bug with NBD since it's 
inception where it uses a 32 bit number for keeping track of the size 
of the device, I fixed it with

nbd: use loff_t for blocksize and nbd_set_size args

It'll be in 4.10.  Thanks,

Josef


  reply	other threads:[~2017-01-15  1:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-14 23:31 NBD: exported files over something around 1 TiB get an insane device size on the client side and are actually empty Christoph Anton Mitterer
2017-01-15  1:03 ` Josef Bacik [this message]
2017-01-15  1:27   ` Christoph Anton Mitterer
2017-01-15  4:27   ` Christoph Anton Mitterer
2017-01-15  7:13   ` [Nbd] " Alex Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484442228.7132.0@smtp.office365.com \
    --to=jbacik@fb.com \
    --cc=calestyo@scientia.net \
    --cc=linux-block@vger.kernel.org \
    --cc=nbd-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.