Re: [PATCH] tpm-emulator: add a TPM emulator pass through

[James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>]

On Sun, 2017-01-15 at 21:25 -0500, Stefan Berger wrote:
> On 01/15/2017 02:40 PM, James Bottomley wrote:
> > On Sun, 2017-01-15 at 14:18 -0500, Stefan Berger wrote:
> > > On 01/09/2017 03:06 PM, James Bottomley wrote:
> > > > > 
> > > > > Thanks. I fixed this now to make it at least compilable. The
> > > > > more
> > > > > recent branch is the tpm2-preview.rev138, which makes that
> > > > > other
> > > > > branch more or less obsolete.
> > > > OK, with this branch, I can get a mostly successful run of the
> > > > smoke tests.  The failure looks to be a dispute over who
> > > > handles
> > > > TPM_RC_RETRY
> > > The following now also works after a (forced) updated on the
> > > swtpm
> > > TPM2 preview branch:
> > > 
> > > swtpm chardev --vtpm-proxy --tpmstate dir=/tmp --tpm2
> > > swtpm chardev --vtpm-proxy --tpmstate dir=/tmp
> > What would it take to get this into the master branch and released,
> > so
> > those of us who use standard distribution tools can get it?
> 
> The problem lies in the code that writes the TPM 2 state in host
> format 
> rather than in Big Endian format, which would make the state portable
> and likely that is the preferred format for QEMU integration. Besides
> that there is some functionality missing for suspending the volatile 
> state of the TPM 2.
> 
> 
> https://github.com/stefanberger/libtpms/wiki

Yes, but my point is that most people who want to be using tpm2
emulation don't really care about QEMU ... it's a nice thing, sure, but
it's very complex to set up, so it's only going to be the odd
enthusiast that cares about vtpm in QEMU.  Most people simply care
about testing TPM2 code or playing with TPM2 itself and for that, they
don't need  or want virtualization.

Could you not push tpm2 into the release branch with the caveat that
the extremely esoteric BE on LE virtualization case doesn't work yet?

James



------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi