diff for duplicates of <1484593637.2133.152.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 7943b50..42eb8bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,17 +14,17 @@ On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote: So, more comments/questions below. -> -> sccr1_reg = pxa2xx_spi_read(drv_data, SSCR1); -> +> ? +> ? sccr1_reg = pxa2xx_spi_read(drv_data, SSCR1); +> ? > - /* Ignore possible writes if we don't need to write */ > - if (!(sccr1_reg & SSCR1_TIE)) > - mask &= ~SSSR_TFS; > - -> /* Ignore RX timeout interrupt if it is disabled */ -> if (!(sccr1_reg & SSCR1_TINTE)) -> mask &= ~SSSR_TINT; -> +> ? /* Ignore RX timeout interrupt if it is disabled */ +> ? if (!(sccr1_reg & SSCR1_TINTE)) +> ? mask &= ~SSSR_TINT; +> ? > - if (!(status & mask)) > - return IRQ_NONE; > + while (1) { @@ -36,7 +36,7 @@ bit be set again during a loop? > */ > + if (!(sccr1_reg & SSCR1_TIE)) > + mask &= ~SSSR_TFS; -> +> ? > - if (!drv_data->master->cur_msg) { > - handle_bad_msg(drv_data); > - /* Never fail */ @@ -57,7 +57,7 @@ bit be set again during a loop? So, we might call handler several times. This needs to be commented in the code why you do so. -> +> ? > - return drv_data->transfer_handler(drv_data); > + status = pxa2xx_spi_read(drv_data, SSSR); @@ -66,14 +66,10 @@ Would it be possible to get all 1:s from the register > + sccr1_reg = pxa2xx_spi_read(drv_data, SSCR1); > + } -> } -> -> /* +> ?} +> ? +> ?/* -- -Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> +Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy --- -To unsubscribe from this list: send the line "unsubscribe linux-spi" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index aae5138..936d5ab 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,9 @@ "ref\0cover.1484592296.git.jan.kiszka@siemens.com\0" "ref\07b15a0910a3ad861fd32161c72559bafa7b71e29.1484592296.git.jan.kiszka@siemens.com\0" - "ref\07b15a0910a3ad861fd32161c72559bafa7b71e29.1484592296.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org\0" - "From\0Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts\0" + "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" + "Subject\0[PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts\0" "Date\0Mon, 16 Jan 2017 21:07:17 +0200\0" - "To\0Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>" - " Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org> - Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> - " Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote:\n" @@ -32,17 +22,17 @@ "\n" "So, more comments/questions below.\n" "\n" - "> \302\240\n" - "> \302\240\tsccr1_reg = pxa2xx_spi_read(drv_data, SSCR1);\n" - "> \302\240\n" + "> ?\n" + "> ?\tsccr1_reg = pxa2xx_spi_read(drv_data, SSCR1);\n" + "> ?\n" "> -\t/* Ignore possible writes if we don't need to write */\n" "> -\tif (!(sccr1_reg & SSCR1_TIE))\n" "> -\t\tmask &= ~SSSR_TFS;\n" "> -\n" - "> \302\240\t/* Ignore RX timeout interrupt if it is disabled */\n" - "> \302\240\tif (!(sccr1_reg & SSCR1_TINTE))\n" - "> \302\240\t\tmask &= ~SSSR_TINT;\n" - "> \302\240\n" + "> ?\t/* Ignore RX timeout interrupt if it is disabled */\n" + "> ?\tif (!(sccr1_reg & SSCR1_TINTE))\n" + "> ?\t\tmask &= ~SSSR_TINT;\n" + "> ?\n" "> -\tif (!(status & mask))\n" "> -\t\treturn IRQ_NONE;\n" "> +\twhile (1) {\n" @@ -54,7 +44,7 @@ "> */\n" "> +\t\tif (!(sccr1_reg & SSCR1_TIE))\n" "> +\t\t\tmask &= ~SSSR_TFS;\n" - "> \302\240\n" + "> ?\n" "> -\tif (!drv_data->master->cur_msg) {\n" "> -\t\thandle_bad_msg(drv_data);\n" "> -\t\t/* Never fail */\n" @@ -75,7 +65,7 @@ "So, we might call handler several times. This needs to be commented in\n" "the code why you do so.\n" "\n" - "> \302\240\n" + "> ?\n" "> -\treturn drv_data->transfer_handler(drv_data);\n" "> +\t\tstatus = pxa2xx_spi_read(drv_data, SSSR);\n" "\n" @@ -84,16 +74,12 @@ "\n" "> +\t\tsccr1_reg = pxa2xx_spi_read(drv_data, SSCR1);\n" "> +\t}\n" - "> \302\240}\n" - "> \302\240\n" - "> \302\240/*\n" + "> ?}\n" + "> ?\n" + "> ?/*\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" - "Intel Finland Oy\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-spi\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" + Intel Finland Oy -c5ac7cf279010526970e5272909cf77311cccbd04c5479ce5794a2a0c5b37b18 +9e7ed0a22b43b633a45b08135fc759ee3a508e8b442a91c46d3896d033a52ec1
diff --git a/a/1.txt b/N2/1.txt index 7943b50..5b06505 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -71,9 +71,5 @@ Would it be possible to get all 1:s from the register > /* -- -Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> +Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy --- -To unsubscribe from this list: send the line "unsubscribe linux-spi" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index aae5138..14329ea 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,19 +1,18 @@ "ref\0cover.1484592296.git.jan.kiszka@siemens.com\0" "ref\07b15a0910a3ad861fd32161c72559bafa7b71e29.1484592296.git.jan.kiszka@siemens.com\0" - "ref\07b15a0910a3ad861fd32161c72559bafa7b71e29.1484592296.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org\0" - "From\0Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" "Subject\0Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts\0" "Date\0Mon, 16 Jan 2017 21:07:17 +0200\0" - "To\0Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>" - " Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org> - Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> - " Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "To\0Jan Kiszka <jan.kiszka@siemens.com>" + " Mark Brown <broonie@kernel.org>\0" + "Cc\0linux-spi@vger.kernel.org" + linux-arm-kernel@lists.infradead.org + Daniel Mack <daniel@zonque.org> + Haojian Zhuang <haojian.zhuang@gmail.com> + Robert Jarzmik <robert.jarzmik@free.fr> + linux-kernel@vger.kernel.org + Mika Westerberg <mika.westerberg@linux.intel.com> + " Jarkko Nikula <jarkko.nikula@linux.intel.com>\0" "\00:1\0" "b\0" "On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote:\n" @@ -89,11 +88,7 @@ "> \302\240/*\n" "\n" "-- \n" - "Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" - "Intel Finland Oy\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-spi\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" + Intel Finland Oy -c5ac7cf279010526970e5272909cf77311cccbd04c5479ce5794a2a0c5b37b18 +b169e62aff8e3ff541b24dc070f3cf1e2def641da9844d711cc6e4a335b9a76d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.