From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/5] xen: sched: impove use of cpumask scratch space in Credit1.
Date: Wed, 18 Jan 2017 10:54:45 +0100 [thread overview]
Message-ID: <1484733285.7492.67.camel@citrix.com> (raw)
In-Reply-To: <587F4738020000780013120D@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 998 bytes --]
On Wed, 2017-01-18 at 02:45 -0700, Jan Beulich wrote:
> > > > On 17.01.17 at 18:27, <dario.faggioli@citrix.com> wrote:
> > --- a/xen/include/xen/sched-if.h
> > +++ b/xen/include/xen/sched-if.h
> > @@ -47,6 +47,13 @@ DECLARE_PER_CPU(struct schedule_data,
> > schedule_data);
> > DECLARE_PER_CPU(struct scheduler *, scheduler);
> > DECLARE_PER_CPU(struct cpupool *, cpupool);
> >
> > +/*
> > + * Scratch space, for avoiding having too many cpumask_var_t on
> > the stack.
>
> Mind dropping the stray / misleading _var infix from here?
>
Ah, sure!
> There's
> no problem having many cpumask_var_t-s on the stack, as they're
> small. cpumask_t instances are problematic.
>
Of course. Will do.
Thanks,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-18 9:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 17:26 [PATCH 0/5] xen: sched: scheduling (mostly, Credit2) and cpupool fixes and improvements Dario Faggioli
2017-01-17 17:26 ` [PATCH 1/5] xen: credit2: use the correct scratch cpumask Dario Faggioli
2017-01-19 12:22 ` George Dunlap
2017-01-17 17:26 ` [PATCH 2/5] xen: credit2: never consider CPUs outside of our cpupool Dario Faggioli
2017-01-19 8:08 ` Juergen Gross
2017-01-19 8:22 ` Dario Faggioli
2017-01-23 14:40 ` George Dunlap
2017-01-24 12:35 ` Juergen Gross
2017-01-24 12:49 ` Dario Faggioli
2017-01-24 16:37 ` George Dunlap
2017-01-23 15:20 ` George Dunlap
2017-02-03 8:41 ` Jan Beulich
2017-02-03 15:27 ` Dario Faggioli
2017-02-03 15:40 ` Jan Beulich
2017-02-08 16:48 ` Dario Faggioli
2017-02-08 17:02 ` Jan Beulich
2017-02-08 18:55 ` Dario Faggioli
2017-02-09 9:17 ` Jan Beulich
2017-02-09 9:25 ` Dario Faggioli
2017-02-09 10:32 ` Dario Faggioli
2017-01-17 17:26 ` [PATCH 3/5] xen: credit2: fix shutdown/suspend when playing with cpupools Dario Faggioli
2017-01-23 15:42 ` George Dunlap
2017-01-17 17:27 ` [PATCH 4/5] xen: sched: impove use of cpumask scratch space in Credit1 Dario Faggioli
2017-01-18 9:45 ` Jan Beulich
2017-01-18 9:54 ` Dario Faggioli [this message]
2017-01-23 15:47 ` George Dunlap
2017-01-17 17:27 ` [PATCH 5/5] xen: sched: simplify ACPI S3 resume path Dario Faggioli
2017-01-23 15:52 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484733285.7492.67.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.