From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vladimir Zapolskiy <vz@mleia.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ramiro.Oliveira@synopsys.com,
Joao Pinto <Joao.Pinto@synopsys.com>,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH] i2c: core: helper function to detect slave mode
Date: Wed, 18 Jan 2017 12:59:36 +0200 [thread overview]
Message-ID: <1484737176.2133.191.camel@linux.intel.com> (raw)
In-Reply-To: <f751ffbe-f9f8-c5bd-3b1a-2edd91152a78@mleia.com>
On Tue, 2017-01-17 at 01:14 +0200, Vladimir Zapolskiy wrote:
> review comments then, for example it is not obvious that on a platform
> with both CONFIG_ACPI and CONFIG_OF enabled there should be an
> exclusive
> selection of only one of two possible branches as in your code etc.
ACPI and DT approach differently to this property. Like I already said
to you check GPIO library where we have similarities.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-01-18 11:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 17:24 [PATCH] i2c: core: helper function to detect slave mode Luis Oliveira
2017-01-05 17:24 ` Luis Oliveira
2017-01-06 16:29 ` Andy Shevchenko
2017-01-06 17:15 ` Luis Oliveira
2017-01-06 17:15 ` Luis Oliveira
[not found] ` <475d9c2a-da11-97d0-d0b6-37ccd4990f18-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-01-06 17:17 ` Andy Shevchenko
2017-01-06 17:17 ` Andy Shevchenko
2017-01-06 17:46 ` Luis Oliveira
2017-01-06 17:46 ` Luis Oliveira
[not found] ` <c73ee9ab-64a1-0419-314d-21d4575ca7bf-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-01-06 21:32 ` Andy Shevchenko
2017-01-06 21:32 ` Andy Shevchenko
2017-01-06 16:35 ` Rob Herring
[not found] ` <CAL_JsqK1=R6M=vrW5aqmQtMHUGGws_Hb=VHb9RNcvesjfkCjRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-06 17:12 ` Luis Oliveira
2017-01-06 17:12 ` Luis Oliveira
[not found] ` <f4ec62119145bc70c938800c91eb396d30457304.1483636071.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-01-06 21:46 ` Vladimir Zapolskiy
2017-01-06 21:46 ` Vladimir Zapolskiy
[not found] ` <73246c4a-504c-52d7-dde4-970a45dca0bd-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2017-01-06 22:45 ` Andy Shevchenko
2017-01-06 22:45 ` Andy Shevchenko
2017-01-06 23:43 ` Vladimir Zapolskiy
[not found] ` <b5788d1d-c951-0fc3-eed8-88457df1f27e-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2017-01-07 0:19 ` Andy Shevchenko
2017-01-07 0:19 ` Andy Shevchenko
[not found] ` <CAHp75Ve7zNN3m1ngLGi-81mFehKzZG07mh5H2T5+_k-=jJqqNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-07 1:24 ` Vladimir Zapolskiy
2017-01-07 1:24 ` Vladimir Zapolskiy
2017-01-12 17:01 ` Andy Shevchenko
2017-01-16 10:32 ` Luis Oliveira
2017-01-16 10:32 ` Luis Oliveira
[not found] ` <7fdf5d3c-d0ea-ec45-6b18-4573fff6dd11-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-01-16 23:14 ` Vladimir Zapolskiy
2017-01-16 23:14 ` Vladimir Zapolskiy
2017-01-18 10:59 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484737176.2133.191.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.