From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH] drm/i915: Avoid drm_atomic_state_put(NULL) in intel_display_resume Date: Wed, 18 Jan 2017 13:35:33 +0200 Message-ID: <1484739333.4635.3.camel@gmail.com> References: <20170115125825.18597-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170115125825.18597-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , linux-kernel@vger.kernel.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, "# v4 . 10-rc1+" , Stefan Seyfried List-Id: intel-gfx@lists.freedesktop.org T24gU3VuLCAyMDE3LTAxLTE1IGF0IDEyOjU4ICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g aW50ZWxfZGlzcGxheV9yZXN1bWUoKSBtYXkgYmUgY2FsbGVkIHdpdGhvdXQgYSBhdG9taWMgc3Rh dGUgdG8gcmVzdG9yZSwKPiBpLmUuIGRldl9wcml2LT5tb2Rlc2V0X3Jlc2V0X3Jlc3RvcmUgc3Rh dGUgaXMgTlVMTC4gT25lIHN1Y2ggY2FzZSBpcwo+IGZvbGxvd2luZyBhIGxpZCBvcGVuL2Nsb3Nl IGV2ZW50IGFuZCB0aGUgZm9yY2VkIG1vZGVzZXQgaW4KPiBpbnRlbF9saWRfbm90aXkoKS4KPiAK PiBSZXBvcnRlZC1ieTogU3RlZmFuIFNleWZyaWVkIDxzdGVmYW4uc2V5ZnJpZWRAZ29vZ2xlbWFp bC5jb20+Cj4gRml4ZXM6IDA4NTM2OTVjM2JhNCAoImRybTogQWRkIHJlZmVyZW5jZSBjb3VudGlu ZyB0byBkcm1fYXRvbWljX3N0YXRlIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNv bT4KPiBDYzogPGRybS1pbnRlbC1maXhlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmc+ICMgdjQuMTAt cmMxKwo+IC0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMyAr Ky0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAzZGM4NzI0ZGY0MDAu LjI2MGJiZTg4ODFlNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBA QCAtMTcwMjQsNyArMTcwMjQsOCBAQCB2b2lkIGludGVsX2Rpc3BsYXlfcmVzdW1lKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gwqAKPiDCoAlpZiAocmV0KQo+IMKgCQlEUk1fRVJST1IoIlJlc3Rv cmluZyBvbGQgc3RhdGUgZmFpbGVkIHdpdGggJWlcbiIsIHJldCk7Cj4gLQlkcm1fYXRvbWljX3N0 YXRlX3B1dChzdGF0ZSk7Cj4gKwlpZiAoc3RhdGUpCj4gKwkJZHJtX2F0b21pY19zdGF0ZV9wdXQo c3RhdGUpOwo+IMKgfQo+IMKgCj4gwqB2b2lkIGludGVsX21vZGVzZXRfZ2VtX2luaXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKCgpSZXZpZXdlZC1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZl aXJhIDxjb25zZWx2YW4yQGdtYWlsLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100AbdARLnf (ORCPT ); Wed, 18 Jan 2017 06:43:35 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33847 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819AbdARLnb (ORCPT ); Wed, 18 Jan 2017 06:43:31 -0500 Message-ID: <1484739333.4635.3.camel@gmail.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid drm_atomic_state_put(NULL) in intel_display_resume From: Ander Conselvan De Oliveira To: Chris Wilson , linux-kernel@vger.kernel.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, "# v4 . 10-rc1+" , Stefan Seyfried Date: Wed, 18 Jan 2017 13:35:33 +0200 In-Reply-To: <20170115125825.18597-1-chris@chris-wilson.co.uk> References: <20170115125825.18597-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-01-15 at 12:58 +0000, Chris Wilson wrote: > intel_display_resume() may be called without a atomic state to restore, > i.e. dev_priv->modeset_reset_restore state is NULL. One such case is > following a lid open/close event and the forced modeset in > intel_lid_notiy(). > > Reported-by: Stefan Seyfried > Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state") > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: # v4.10-rc1+ > --- >  drivers/gpu/drm/i915/intel_display.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 3dc8724df400..260bbe8881e6 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -17024,7 +17024,8 @@ void intel_display_resume(struct drm_device *dev) >   >   if (ret) >   DRM_ERROR("Restoring old state failed with %i\n", ret); > - drm_atomic_state_put(state); > + if (state) > + drm_atomic_state_put(state); >  } >   >  void intel_modeset_gem_init(struct drm_device *dev) Reviewed-by: Ander Conselvan de Oliveira