From: Doug Ledford <dledford@redhat.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>,
Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org,
Linux Netdev List <netdev@vger.kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Eddie Wai <eddie.wai@broadcom.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs
Date: Thu, 19 Jan 2017 01:57:33 -0500 [thread overview]
Message-ID: <1484809053.2406.90.camel@redhat.com> (raw)
In-Reply-To: <CA+sbYW0+Z2X+_BqG=QNBSgc0Qsk1S9sZYieUuN05PjF5or4NkQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Wed, 2017-01-18 at 14:42 +0530, Selvin Xavier wrote:
> On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky <leon@kernel.org>
> wrote:
> >
> > It is better to use already existing macros - min()
> > cq->max_cql = min(entries, MAX_CQL_PER_POLL);
> >
> > I afraid that you can't avoid the respinning, you have more than
> > month
> > till merge window.
> >
> > Can you please remove useless wrappers and try to reuse kernel
> > macros?
>
> Leon,
> Thanks for your comments. I will include your both comments in the
> next patch set.
>
> Doug,
> Is it ok if I send out the V5 now after re-basing against for-4.11
> branch or should i wait for your comments on V4?
Wait.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-01-19 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 9:12 [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs Selvin Xavier
2017-01-19 6:57 ` Doug Ledford [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-21 11:41 [PATCH for bnxt_re V4 00/21] Broadcom RoCE Driver (bnxt_re) Selvin Xavier
[not found] ` <1482320530-5344-1-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-12-21 11:41 ` [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs Selvin Xavier
[not found] ` <1482320530-5344-11-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-01-18 8:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484809053.2406.90.camel@redhat.com \
--to=dledford@redhat.com \
--cc=devesh.sharma@broadcom.com \
--cc=eddie.wai@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.