Re: [[PATCH][yocto-autobuilder] 1/2] buildsteps/CreateAutoConf.py: Add support for specify MACHINE by build prop

[Beth 'pidge' Flanagan <pidge@toganlabs.com>]

On Wed, 2017-01-18 at 18:13 +0000, Joshua Lock wrote:
> On Mon, 2017-01-16 at 10:25 -0600, Aníbal Limón wrote:
> > 
> > Sometimes is a good idea to could specify a machine to build via a
> > build
> > property.
> Why's that? I can guess but the commit log should really tell me what
> the motivation for the change is.

I agree. Please submit a v2 with a bit better of a commit log.

-b

> 
> > 
> > 
> > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> > ---
> >  .../site-
> > packages/autobuilder/buildsteps/CreateAutoConf.py          | 6
> > +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/python2.7/site-
> > packages/autobuilder/buildsteps/CreateAutoConf.py
> > b/lib/python2.7/site-
> > packages/autobuilder/buildsteps/CreateAutoConf.py
> > index 021f542..7915dd5 100644
> > --- a/lib/python2.7/site-
> > packages/autobuilder/buildsteps/CreateAutoConf.py
> > +++ b/lib/python2.7/site-
> > packages/autobuilder/buildsteps/CreateAutoConf.py
> > @@ -174,7 +174,11 @@ class CreateAutoConf(ShellCommand):
> >                      fout = fout + 'baselib = \\042${@d.getVar(\\04
> > 7B
> > ASE_LIB_tune-\\047 + (d.getVar(\\047DEFAULTTUNE\\047, True) or
> > \\047INVALID\\047), True) or \\047lib\\047}\\042 \n'
> >              if self.distro == "poky-rt":
> >                  fout = fout +
> > 'PREFERRED_PROVIDER_virtual/kernel="linux-yocto-rt" \n'
> > -            machine=self.machine
> > +            machine=self.getProperty('custom_machine')
> > +            if machine:
> > +                self.machine = machine
> > +            else:
> > +                machine = self.machine
> >              if layerversion is not None and int(layerversion) > 1:
> >                  if self.machine == "atom-pc":
> >                      machine = self.machine.replace("atom-pc",
> > "genericx86")