All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
	devel@driverdev.osuosl.org,
	"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be non-atomic
Date: Thu, 19 Jan 2017 12:46:12 +0200	[thread overview]
Message-ID: <1484822772.2133.225.camel@linux.intel.com> (raw)
In-Reply-To: <20170119094914.GA5162@kroah.com>

On Thu, 2017-01-19 at 10:49 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote:
> > First of all, fbtft in current state doesn't allow to override GPIOs
> > to be
> > optional, like "reset" one. It might be a bug somewhere, but rather
> > out of
> > scope of this fix.
> > 
> > Second, not all GPIOs available on the board would be SoC based,
> > some of them
> > might sit on I2C GPIO expanders, for example, on Intel
> > Edison/Arduino, and thus
> > any communication with them might sleep.
> > 
> > Besides that using udelay() and mdelay() is kinda resource wasteful.
> > 
> > Summarize all of the above, convert fbtft_reset() function to non-
> > atomic
> > variant by using gpio_set_value_cansleep(), usleep_range(), and
> > msleep().
> > 
> > Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Andy, this series came through with the charmap all corrupted and git
> didn't like them at all.  Can you fix up and resend?

Strange. I used usual git send-email. Okay, just resent (as v4).

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-01-19 10:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 18:29 [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI Andy Shevchenko
2017-01-03 18:29 ` [PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be non-atomic Andy Shevchenko
2017-01-19  9:49   ` Greg Kroah-Hartman
2017-01-19 10:46     ` Andy Shevchenko [this message]
2017-01-03 18:29 ` [PATCH v3 2/5] staging: fbtft: remove custom DMA mapped buffer Andy Shevchenko
2017-01-03 18:29 ` [PATCH v3 3/5] staging: fbtft: propagate error code from kstrto*() Andy Shevchenko
2017-01-03 18:29 ` [PATCH v3 4/5] staging: fbtft: fb_ssd1306: Support smaller screen sizes Andy Shevchenko
2017-01-03 18:29 ` [PATCH v3 5/5] staging: fbtft: fb_ssd1306: Refactor write_vmem() Andy Shevchenko
2017-01-11 14:43 ` [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI Andy Shevchenko
2017-01-11 16:10   ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484822772.2133.225.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.