From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 8209E71C22 for ; Thu, 19 Jan 2017 16:05:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v0JG5Mq1001656; Thu, 19 Jan 2017 16:05:22 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5eZNYLozh9c3; Thu, 19 Jan 2017 16:05:22 +0000 (GMT) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v0JG5IWQ001652 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 19 Jan 2017 16:05:19 GMT Message-ID: <1484841918.4367.426.camel@linuxfoundation.org> From: Richard Purdie To: Mark Hatle , Robert Yang , bitbake-devel Date: Thu, 19 Jan 2017 16:05:18 +0000 In-Reply-To: <8d3f903a-0ff2-8c27-e2bc-258ad2c7fd7d@windriver.com> References: <1484821262.4367.424.camel@linuxfoundation.org> <8d3f903a-0ff2-8c27-e2bc-258ad2c7fd7d@windriver.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Subject: Re: Filename too long X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 16:05:25 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Thu, 2017-01-19 at 09:07 -0600, Mark Hatle wrote: > On 1/19/17 4:21 AM, Richard Purdie wrote: > > > > On Thu, 2017-01-19 at 14:13 +0800, Robert Yang wrote: > > >  > > Looking at the code in your patch, this second piece clearly isn't > > true > > due to this code: > > > >           if gitsrcname.startswith('.'): > >               gitsrcname = gitsrcname[1:] > > > > I also don't believe this patch is correct since we're meant to be > > creating a filename, not a path and if you leave the '/' characters > > in, > > it isn't a filename. I think we likely just need to truncate the > > path > > to the last say 225 chars if its over length. The unique piece > > should > > be towards the right hand end of the name. > Ok.. I can certainly implement that.  Should the truncation be in the > lockfile code or in the code that generatd the name itself? Gut feeling says I think the generated name is safest. Cheers, Richard