From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling Date: Thu, 19 Jan 2017 17:19:20 +0100 Message-ID: <1484842760.7492.148.camel@citrix.com> References: <1484769406-17416-1-git-send-email-ronladred@gmail.com> <1484769406-17416-2-git-send-email-ronladred@gmail.com> <1484777791.7492.118.camel@citrix.com> <20170119151337.GB21971@fedora.fios-router.home> <4bf134fd-b985-3579-41ef-e61a30aa8889@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7018005772854500725==" Return-path: In-Reply-To: <4bf134fd-b985-3579-41ef-e61a30aa8889@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , Ronald Rojas Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============7018005772854500725== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-tY1aSYGF2K0adHRnGQyK" --=-tY1aSYGF2K0adHRnGQyK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-01-19 at 16:02 +0000, George Dunlap wrote: > On 19/01/17 15:13, Ronald Rojas wrote: > > It's possible to add the errors as part of the first patch and then > > add the context functions as the second patch as Go will at least=C2=A0 > > let you compile the errors on it's own. I can swap the order of the > > patchs in the next revision. >=20 > Which points out the problem with Dario's suggestion. :-) >=20 > It is indeed normal that you don't fix things from previous patches. > But the "fix" here is from the very first patch: you can't introduce > the > error code before you introduce the directories and the makefile to > build it.=C2=A0=C2=A0 > Sure! But, OOC, is it imperative that the makefile is introduced in the first patch? I think that if it were me doing something like this, I'd defer introducing it, if not at the very end, not before than when there is something meaningful to make. A matter of taste, at least up to a certain extent, I know. > But that of course means that you're not separating out the important > things from the first patch (the Makefile setup) with the important > things from the second patch (the Error handling design). >=20 > I'd prefer it be left as it is;=20 > Sure. I'd at least remove the '//FIXME' from patch 1, especially considering that the changelog already says that error handling will be reworked. > but it's Ian and Wei that have the final > word on that. >=20 Indeed. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-tY1aSYGF2K0adHRnGQyK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYgOcIAAoJEBZCeImluHPuTYIQANCZoA5/JX+nzjoFl4jY1MES A43sluYsDfUoYhBrnlc0SkvRnIiOGZIOOivm//FdfyDWAJzM7cJd2FEngQSwk9Tg zCj6lgqJIIvYMpeJoLF7u0lNihQpiDeTRSlRAQ6navorTb3kqETZ2isc+q/Hg+EN ZU0wwLRbXon8QM4mn80MJ6CHLXXaiS6xXEbCqThIfqliL1wvsfyf7i/RjBvAfQm0 nN+i2Jyzrlj4nx5qCJJFrq6uM9sRWSAX7Rt3ICobwu6wY+75BSjSGkpc+QpLQAo7 aVyymUucuOrdj2E3fsn1CVM+KnzVJMYDNWCoQ1pFqXC0S+uWkev4MIrhpGToozKV 2ZaYHJiRBt/wSxBXr+8PWEpGAEHj86jpBqgcj/O8N+Ky7SDgJwaF48QGl9xBdXlq TZ1fjuEqVVl5mBJZp6sSYL46K3C1nmYlgFpkp6SmGzi6M6YXGTLntwP1Nbi6iscG lsJs8PoKfnOOaa21IbazIa1ZclWGCkLbdHsP3j1ojEFmVqlniCMwF1GV4vtt9Mra D9mcd+/9qZBQY9h6MaElkvq5zcUWGaIOulfOOaWGELuqmXD2kloEJBOFCZpsvX16 yn3jwChNC1zsfhkUwPD7eDMef1DTveiCqDQiuPTSqO4HYAI0ZZeEQcqB6rsiqp6+ lMwQUHPuuWARAKpEAhqp =K/yK -----END PGP SIGNATURE----- --=-tY1aSYGF2K0adHRnGQyK-- --===============7018005772854500725== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7018005772854500725==--