diff for duplicates of <1484936477.17477.97.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index d06c220..aa941cb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,8 +4,8 @@ thanks for respond. I'm agree with most of the comments. My comments below. -On Fri, 2017-01-20@15:38 +0200, Andy Shevchenko wrote: -> On Fri, 2017-01-20@13:50 +0300, Eugeniy Paltsev wrote: +On Fri, 2017-01-20 at 15:38 +0200, Andy Shevchenko wrote: +> On Fri, 2017-01-20 at 13:50 +0300, Eugeniy Paltsev wrote: > > > > This patch adds support for the DW AXI DMAC controller. > > @@ -17,12 +17,12 @@ On Fri, 2017-01-20@15:38 +0200, Andy Shevchenko wrote: > > Note: there is no DT documentation in this patch yet, but it will > > be added in the nearest future. > First of all, please use virt-dma API. -Is it?necessary? -I couldn't find any notes about virt-dma in documentation.? +Is it necessary? +I couldn't find any notes about virt-dma in documentation. > Second, don't look to dw_dmac for examples, it's not a good one to be > learned from. -Any suggestions about DMA driver to look for?examples? +Any suggestions about DMA driver to look for examples? > > Some mostly style comments below. @@ -59,7 +59,7 @@ Any suggestions about DMA driver to look for?examples? > > interfaces), but > > + * it depends on IP block configurarion. > > + */ -> > +#define AXI_DMA_BUSWIDTHS ??\ +> > +#define AXI_DMA_BUSWIDTHS \ > > + (DMA_SLAVE_BUSWIDTH_UNDEFINED | \ > > + DMA_SLAVE_BUSWIDTH_1_BYTE | \ > > + DMA_SLAVE_BUSWIDTH_2_BYTES | \ @@ -114,16 +114,16 @@ reduce space. > assembly? > Does it indeed do what it's supposed to? Yes, i looked into assembly. -I used "likely()" because?irq_mask will be equal DWAXIDMAC_IRQ_ALL in +I used "likely()" because irq_mask will be equal DWAXIDMAC_IRQ_ALL in 99.9% of this function call. -It is?useful here, am I wrong? +It is useful here, am I wrong? > > > > +static inline void axi_chan_disable(struct axi_dma_chan *chan) > > +{ > > + u32 val = axi_dma_ioread32(chan->chip, DMAC_CHEN); > > + val &= ~((1 << chan->id) << DMAC_CHAN_EN_SHIFT); -> > + val |=??((1 << chan->id) << DMAC_CHAN_EN_WE_SHIFT); +> > + val |= ((1 << chan->id) << DMAC_CHAN_EN_WE_SHIFT); > You talked somewhere of a BIT macro, here it is one > > val &= ~BIT(chan->id + DMAC_CHAN_EN_SHIFT); @@ -160,7 +160,7 @@ dmac if all channels are unused for now. > > > > +static u32 axi_chan_get_xfer_width(struct axi_dma_chan *chan, > > dma_addr_t src, -> > + ???dma_addr_t dst, size_t len) +> > + dma_addr_t dst, size_t len) > > +{ > > > > + u32 width; @@ -244,7 +244,7 @@ dmac if all channels are unused for now. > It will not work for 64 bits, it will not work for other users of > this > driver if any (when you have different DMA mask to be set). -Looks like I misunderstood?dma_coerce_mask_and_coherent purposes of +Looks like I misunderstood dma_coerce_mask_and_coherent purposes of using. > @@ -267,7 +267,7 @@ using. > > + > > + ret = devm_request_irq(chip->dev, chip->irq, > > dw_axi_dma_intretupt, -> > + ???????IRQF_SHARED, DRV_NAME, chip); +> > + IRQF_SHARED, DRV_NAME, chip); > > + if (ret) > > + return ret; > > + @@ -322,9 +322,9 @@ using. > > +MODULE_DESCRIPTION("Synopsys DesignWare AXI DMA Controller > > platform > > driver"); -> > +MODULE_AUTHOR("Paltsev Eugeniy <Eugeniy.Paltsev at synopsys.com>"); -> FirstName LastName <email at address.com> ? +> > +MODULE_AUTHOR("Paltsev Eugeniy <Eugeniy.Paltsev@synopsys.com>"); +> FirstName LastName <email@address.com> ? > > -- -?Paltsev Eugeniy + Paltsev Eugeniy diff --git a/a/content_digest b/N1/content_digest index f2302f2..f49a656 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,16 @@ "ref\01484909414-21078-1-git-send-email-Eugeniy.Paltsev@synopsys.com\0" "ref\01484919509.2133.270.camel@linux.intel.com\0" - "From\0Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)\0" - "Subject\0[RFC] dmaengine: Add DW AXI DMAC driver\0" + "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" + "Subject\0Re: [RFC] dmaengine: Add DW AXI DMAC driver\0" "Date\0Fri, 20 Jan 2017 18:21:18 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0dmaengine@vger.kernel.org <dmaengine@vger.kernel.org>" + " andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com>\0" + "Cc\0dan.j.williams@intel.com <dan.j.williams@intel.com>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com> + Alexey.Brodkin@synopsys.com <Alexey.Brodkin@synopsys.com> + vinod.koul@intel.com <vinod.koul@intel.com> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi Andy,\n" @@ -12,8 +19,8 @@ "I'm agree with most of the comments.\n" "My comments below.\n" "\n" - "On Fri, 2017-01-20@15:38 +0200, Andy Shevchenko wrote:\n" - "> On Fri, 2017-01-20@13:50 +0300, Eugeniy Paltsev wrote:\n" + "On Fri, 2017-01-20 at 15:38 +0200, Andy Shevchenko wrote:\n" + "> On Fri, 2017-01-20 at 13:50 +0300, Eugeniy Paltsev wrote:\n" "> > \n" "> > This patch adds support for the DW AXI DMAC controller.\n" "> > \n" @@ -25,12 +32,12 @@ "> > Note: there is no DT documentation in this patch yet, but it will\n" "> > be added in the nearest future.\n" "> First of all, please use virt-dma API.\n" - "Is it?necessary?\n" - "I couldn't find any notes about virt-dma in documentation.?\n" + "Is it\302\240necessary?\n" + "I couldn't find any notes about virt-dma in documentation.\302\240\n" "\n" "> Second, don't look to dw_dmac for examples, it's not a good one to be\n" "> learned from.\n" - "Any suggestions about DMA driver to look for?examples?\n" + "Any suggestions about DMA driver to look for\302\240examples?\n" "\n" "> \n" "> Some mostly style comments below.\n" @@ -67,7 +74,7 @@ "> > interfaces), but\n" "> > + * it depends on IP block configurarion.\n" "> > + */\n" - "> > +#define AXI_DMA_BUSWIDTHS\t\t??\\\n" + "> > +#define AXI_DMA_BUSWIDTHS\t\t\302\240\302\240\\\n" "> > +\t(DMA_SLAVE_BUSWIDTH_UNDEFINED\t| \\\n" "> > +\tDMA_SLAVE_BUSWIDTH_1_BYTE\t| \\\n" "> > +\tDMA_SLAVE_BUSWIDTH_2_BYTES\t| \\\n" @@ -122,16 +129,16 @@ "> assembly?\n" "> Does it indeed do what it's supposed to?\n" "Yes, i looked into assembly.\n" - "I used \"likely()\" because?irq_mask will be equal DWAXIDMAC_IRQ_ALL in\n" + "I used \"likely()\" because\302\240irq_mask will be equal DWAXIDMAC_IRQ_ALL in\n" "99.9% of this function call.\n" - "It is?useful here, am I wrong?\n" + "It is\302\240useful here, am I wrong?\n" "\n" "> > \n" "> > +static inline void axi_chan_disable(struct axi_dma_chan *chan)\n" "> > +{\n" "> > +\tu32 val = axi_dma_ioread32(chan->chip, DMAC_CHEN);\n" "> > +\tval &= ~((1 << chan->id) << DMAC_CHAN_EN_SHIFT);\n" - "> > +\tval |=??((1 << chan->id) << DMAC_CHAN_EN_WE_SHIFT);\n" + "> > +\tval |=\302\240\302\240((1 << chan->id) << DMAC_CHAN_EN_WE_SHIFT);\n" "> You talked somewhere of a BIT macro, here it is one\n" "> \n" "> val &= ~BIT(chan->id + DMAC_CHAN_EN_SHIFT);\n" @@ -168,7 +175,7 @@ "> > \n" "> > +static u32 axi_chan_get_xfer_width(struct axi_dma_chan *chan,\n" "> > dma_addr_t src,\n" - "> > +\t\t\t\t???dma_addr_t dst, size_t len)\n" + "> > +\t\t\t\t\302\240\302\240\302\240dma_addr_t dst, size_t len)\n" "> > +{\n" "> > \n" "> > +\tu32 width;\n" @@ -252,7 +259,7 @@ "> It will not work for 64 bits, it will not work for other users of\n" "> this\n" "> driver if any (when you have different DMA mask to be set).\n" - "Looks like I misunderstood?dma_coerce_mask_and_coherent purposes of\n" + "Looks like I misunderstood\302\240dma_coerce_mask_and_coherent purposes of\n" "using.\n" "\n" "> \n" @@ -275,7 +282,7 @@ "> > +\n" "> > +\tret = devm_request_irq(chip->dev, chip->irq,\n" "> > dw_axi_dma_intretupt,\n" - "> > +\t\t\t???????IRQF_SHARED, DRV_NAME, chip);\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240IRQF_SHARED, DRV_NAME, chip);\n" "> > +\tif (ret)\n" "> > +\t\treturn ret;\n" "> > +\n" @@ -330,11 +337,11 @@ "> > +MODULE_DESCRIPTION(\"Synopsys DesignWare AXI DMA Controller\n" "> > platform\n" "> > driver\");\n" - "> > +MODULE_AUTHOR(\"Paltsev Eugeniy <Eugeniy.Paltsev at synopsys.com>\");\n" - "> FirstName LastName <email at address.com> ?\n" + "> > +MODULE_AUTHOR(\"Paltsev Eugeniy <Eugeniy.Paltsev@synopsys.com>\");\n" + "> FirstName LastName <email@address.com> ?\n" "> \n" "> \n" "-- \n" - ?Paltsev Eugeniy + "\302\240Paltsev Eugeniy" -5a8f6b391254bbcbcc95b532cf18f5231ecbbbd6cbbb3088456da7cdc8e658cf +bcf6d60afbdcd886c05285737506670e1f5d35120248b5913ad60b9e38f3f546
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.