From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Tomi Sarvela <tomi.p.sarvela@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Disable -Woverride-init
Date: Mon, 23 Jan 2017 10:00:40 +0200 [thread overview]
Message-ID: <1485158440.2790.0.camel@linux.intel.com> (raw)
In-Reply-To: <20170118162751.GA27958@nuc-i3427.alporthouse.com>
On ke, 2017-01-18 at 16:27 +0000, Chris Wilson wrote:
> On Wed, Jan 18, 2017 at 05:56:13PM +0200, Joonas Lahtinen wrote:
> >
> > On ke, 2017-01-18 at 12:18 +0000, Chris Wilson wrote:
> > >
> > > -subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror
> > > +subdir-ccflags-y := -Wno-override-init # used frequently for "inheritance"
> >
> > Why always on, if somebody upper level decides to -Werror, this is
> > kinda unexpected for them?
>
> We intentionally use the { .a = 0, .a = 1 }. That is flagged by the set
> of warnings enabled by W=1. If the user is using Werror, then they are
> faced with an intentionally broken build.
>
> Our choice, if we want to be W=1 clean, is to either markup using #pragma
> or turn off the warning.
Guess we can then merge this.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 12:18 [PATCH 1/2] drm/i915: Disable -Woverride-init Chris Wilson
2017-01-18 12:18 ` [PATCH 2/2] drm/i915: Fix W=1 warning for csr_load_work_fn() Chris Wilson
2017-01-18 14:24 ` Mika Kuoppala
2017-01-18 15:56 ` [PATCH 1/2] drm/i915: Disable -Woverride-init Joonas Lahtinen
2017-01-18 16:27 ` Chris Wilson
2017-01-23 8:00 ` Joonas Lahtinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 16:08 Chris Wilson
2017-10-13 16:18 ` Michal Wajdeczko
2017-10-13 16:47 ` Ville Syrjälä
2017-10-13 19:34 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485158440.2790.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.