From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: Priority boost for locked waits
Date: Mon, 23 Jan 2017 10:03:32 +0200 [thread overview]
Message-ID: <1485158612.2790.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170121092526.17833-2-chris@chris-wilson.co.uk>
On la, 2017-01-21 at 09:25 +0000, Chris Wilson wrote:
> We always try to do an unlocked wait before resorting to having a
> blocking wait under the mutex - so we very rarely have to sleep under
> the struct_mutex. However, when we do we want that wait to be as short
> as possible as the struct_mutex is our BKL that will stall the driver and
> all clients.
>
> There should be no impact for all typical workloads.
>
> v2: Move down a layer to apply to all waits.
> v3: Make the priority boost explicit. This makes the paths where we want
> boosting under the mutex clear and prevents boosting priority uselessly
> for when we are waiting for idle.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 8:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 9:25 [PATCH 1/3] drm/i915: Tidy max/display priority macro Chris Wilson
2017-01-21 9:25 ` [PATCH 2/3] drm/i915: Priority boost for locked waits Chris Wilson
2017-01-23 8:03 ` Joonas Lahtinen [this message]
2017-01-23 10:43 ` Tvrtko Ursulin
2017-01-23 10:51 ` Chris Wilson
2017-01-23 11:41 ` Tvrtko Ursulin
2017-01-23 11:50 ` Chris Wilson
2017-01-23 11:56 ` Tvrtko Ursulin
2017-01-21 9:25 ` [PATCH 3/3] drm/i915: Priority boost switching to an idle ring Chris Wilson
2017-01-21 10:09 ` Chris Wilson
2017-01-23 8:39 ` Joonas Lahtinen
2017-01-23 8:48 ` Chris Wilson
2017-01-23 10:51 ` Tvrtko Ursulin
2017-01-23 11:16 ` Chris Wilson
2017-01-23 11:50 ` Tvrtko Ursulin
2017-01-23 12:02 ` Chris Wilson
2017-01-23 8:31 ` [PATCH 1/3] drm/i915: Tidy max/display priority macro Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485158612.2790.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.