From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Assert that the context-switch completion matches our context
Date: Mon, 23 Jan 2017 10:26:00 +0200 [thread overview]
Message-ID: <1485159960.2790.5.camel@linux.intel.com> (raw)
In-Reply-To: <20170121172905.1646-2-chris@chris-wilson.co.uk>
On la, 2017-01-21 at 17:29 +0000, Chris Wilson wrote:
> When execlists signals the context completion, it also provides the
> context id for the status event. Assert that id matches the one we expect.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
<SNIP>
> @@ -595,6 +595,10 @@ static void intel_lrc_irq_handler(unsigned long data)
> if (!(status & GEN8_CTX_STATUS_COMPLETED_MASK))
> continue;
>
> + /* Check the context id for this event matches */
> + GEM_BUG_ON(readl(buf + 2 * idx + 1) !=
> + port[0].request->ctx->hw_id);
> +
> GEM_BUG_ON(port[0].count == 0);
> if (--port[0].count == 0) {
> GEM_BUG_ON(status & GEN8_CTX_STATUS_PREEMPTED);
This is good for now, Mika has to update it for the SVM code, though.
(Counterpart at intel_lr_context_descriptor_update).
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 17:29 [PATCH 1/2] drm/i915: Assert that the kernel_context is hw-id 0 Chris Wilson
2017-01-21 17:29 ` [PATCH 2/2] drm/i915: Assert that the context-switch completion matches our context Chris Wilson
2017-01-23 8:26 ` Joonas Lahtinen [this message]
2017-01-23 8:32 ` Chris Wilson
2017-01-23 8:50 ` [PATCH v2] " Chris Wilson
2017-01-23 10:26 ` Tvrtko Ursulin
2017-01-23 10:30 ` Chris Wilson
2017-01-23 10:44 ` Tvrtko Ursulin
2017-01-23 10:52 ` Chris Wilson
2017-01-23 11:18 ` Mika Kuoppala
2017-01-21 17:54 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Assert that the kernel_context is hw-id 0 Patchwork
2017-01-23 8:07 ` [PATCH 1/2] " Joonas Lahtinen
2017-01-23 10:23 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Assert that the kernel_context is hw-id 0 (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485159960.2790.5.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.