Re: [Qemu-devel] [PATCH] display: cirrus: check vga bits per pixel(bpp) value

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> > > What seems to happen is that blit_is_unsafe() is also called for
> > > CIRRUS_BLTMODE_PATTERNCOPY, but in this case cirrus_blt_srcpitch is
> > > not used. However, because of this new check if its value is 0 then
> > > cirrus_bitblt_common_patterncopy() returns early and becomes a no-op.
> > 
> > inflight vga queue pull request has a fix for that.
> 
> Do you mean:
>  [PATCH] display: cirrus: ignore source pitch value as needed in blit_is_unsafe
>  (Message-Id: <20170109203520.5619-1-brogers@suse.com>)

Yes.

> Because I'm still seeing artifacts on some setups (eg. on win XP).
> As far as I can tell the check is still too strong:
> The rops used by cirrus_bitblt_common_patterncopy seem to only be using
> the destination pitch as far as I can see (all functions in
> cirrus_vga_rop2.h) and in my tests only the destination pitch got
> filled in, the source pitch was left as zero. Adapting the check when
> coming from cirrus_bitblt_common_patterncopy seems to fix the issue for
> me.

> From a3be50cc3e3bb0f5eb784d30048b88333366bdca Mon Sep 17 00:00:00 2001
> From: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Date: Fri, 20 Jan 2017 09:44:39 +0100
> Subject: [PATCH] cirrus: allow zero source pitch in pattern fill rops
> 
> The rops used by cirrus_bitblt_common_patterncopy only use
> the destination pitch, so the source pitch shoul allowed to
> be zero.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

Looks good to me, can you 'git send-email' it to the list?

thanks,
  Gerd