From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/2] device property: export code duplicating array of property entries
Date: Mon, 23 Jan 2017 17:00:38 +0200 [thread overview]
Message-ID: <1485183638.2133.287.camel@linux.intel.com> (raw)
In-Reply-To: <20170123073849.28352-1-dmitry.torokhov@gmail.com>
On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
> When augmenting ACPI-enumerated devices with additional property data
> based
> on DMI info, a module has often several potential property sets, with
> only
> one being active on a given box. In order to save memory it should be
> possible to mark everything and __initdata or __initconst, execute DMI
> match early, and duplicate relevant properties. Then kernel will
> discard
> the rest of them.
>
Looks good to me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Couple of style nitpicks.
>
> +struct property_entry *property_entries_dup(
> + const struct property_entry
> *properties)
Can we use
struct propert_entry *
property_entries_dup(...)
?
> +struct property_entry *property_entries_dup(
> + const struct property_entry
> *properties);
>
Ditto.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-01-23 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 7:38 [PATCH 1/2] device property: export code duplicating array of property entries Dmitry Torokhov
2017-01-23 7:38 ` [PATCH 2/2] device property: allow constify properties Dmitry Torokhov
2017-01-23 14:40 ` Mika Westerberg
2017-01-23 15:01 ` Andy Shevchenko
2017-01-23 14:39 ` [PATCH 1/2] device property: export code duplicating array of property entries Mika Westerberg
2017-01-23 15:00 ` Andy Shevchenko [this message]
2017-01-23 22:46 ` Dmitry Torokhov
2017-01-30 22:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485183638.2133.287.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.