From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0220.hostedemail.com ([216.40.44.220] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cVnu3-000677-2Z for ath10k@lists.infradead.org; Mon, 23 Jan 2017 23:20:00 +0000 Message-ID: <1485213569.12563.32.camel@perches.com> Subject: Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent() From: Joe Perches Date: Mon, 23 Jan 2017 15:19:29 -0800 In-Reply-To: <1485183876-27080-2-git-send-email-srinivas.kandagatla@linaro.org> References: <1485183876-27080-1-git-send-email-srinivas.kandagatla@linaro.org> <1485183876-27080-2-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Srinivas Kandagatla , Kalle Valo Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org On Mon, 2017-01-23 at 15:04 +0000, Srinivas Kandagatla wrote: > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). [] > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless= /ath/ath10k/pci.c [] > @@ -896,7 +896,7 @@ static int ath10k_pci_diag_read_mem(struct ath10k *ar= , u32 address, void *data, > */ > alloc_nbytes =3D min_t(unsigned int, nbytes, DIAG_TRANSFER_LIMIT); > = > - data_buf =3D (unsigned char *)dma_alloc_coherent(ar->dev, > + data_buf =3D (unsigned char *)dma_zalloc_coherent(ar->dev, > alloc_nbytes, > &ce_data_base, > GFP_ATOMIC); trivia: Nicer to realign arguments and remove the unnecessary cast. Perhaps: data_buf =3D dma_zalloc_coherent(ar->dev,=A0alloc_nbytes, &ce_data_base, =A0GFP_ATOMIC); _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:43968 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750739AbdAWX2O (ORCPT ); Mon, 23 Jan 2017 18:28:14 -0500 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave07.hostedemail.com (Postfix) with ESMTP id 7BD5211AD25 for ; Mon, 23 Jan 2017 23:19:33 +0000 (UTC) Message-ID: <1485213569.12563.32.camel@perches.com> (sfid-20170124_002817_962986_AF8FC2BE) Subject: Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent() From: Joe Perches To: Srinivas Kandagatla , Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Jan 2017 15:19:29 -0800 In-Reply-To: <1485183876-27080-2-git-send-email-srinivas.kandagatla@linaro.org> References: <1485183876-27080-1-git-send-email-srinivas.kandagatla@linaro.org> <1485183876-27080-2-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2017-01-23 at 15:04 +0000, Srinivas Kandagatla wrote: > use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). [] > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c [] > @@ -896,7 +896,7 @@ static int ath10k_pci_diag_read_mem(struct ath10k *ar, u32 address, void *data, > */ > alloc_nbytes = min_t(unsigned int, nbytes, DIAG_TRANSFER_LIMIT); > > - data_buf = (unsigned char *)dma_alloc_coherent(ar->dev, > + data_buf = (unsigned char *)dma_zalloc_coherent(ar->dev, > alloc_nbytes, > &ce_data_base, > GFP_ATOMIC); trivia: Nicer to realign arguments and remove the unnecessary cast. Perhaps: data_buf = dma_zalloc_coherent(ar->dev, alloc_nbytes, &ce_data_base,  GFP_ATOMIC);