Re: split scsi passthrough fields out of struct request

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Mon, 2017-01-23 at 16:29 +0100, Christoph Hellwig wrote:
> this series splits the support for SCSI passthrough commands from the
> main struct request.

Hello Christoph,

Sorry that I have not yet had the time to review these patches. But I
cloned git://git.infradead.org/users/hch/block.git, checked out the
block-pc-refactor branch, merged it with v4.10-rc5 and installed it on
a development server. Unfortunately a kernel oops occurred during boot
(see also the attached screenshot). gdb translates the crash address
into the following:

$ gdb vmlinux
(gdb) list *('__scsi_execute.isra.19'+0x13c)
0xffffffff814a690c is in __scsi_execute (drivers/scsi/scsi_lib.c:260).
255                      memset(buffer + (bufflen - rq->resid_len), 0, rq->resid_len);
256
257             if (resid)
258                     *resid = rq->resid_len;
259             if (rq->sense_len)
260                     memcpy(sense, rq->sense, SCSI_SENSE_BUFFERSIZE);
261             ret = req->errors;
262      out:
263             blk_put_request(req);
264

Bart.

[-- Attachment #2: scsi-passthrough-fields.png --]
[-- Type: image/png, Size: 105799 bytes --]