From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 24 Jan 2017 18:23:37 -0800 Subject: [lustre-devel] [PATCH 1/2] staging: lustre: libcfs: use octal permissions In-Reply-To: <715A0C57-2EE3-486E-A5DE-E372366B6BE8@intel.com> References: <20170124174050.6534-1-ernestas.kulik@gmail.com> <715A0C57-2EE3-486E-A5DE-E372366B6BE8@intel.com> Message-ID: <1485311017.12563.48.camel@perches.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Dilger, Andreas" , Ernestas Kulik Cc: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" On Tue, 2017-01-24 at 22:22 +0000, Dilger, Andreas wrote: > On Jan 24, 2017, at 09:40, Ernestas Kulik wrote: > > > > Using octal permissions instead of symbolic ones is preferred. > > Typically the reverse is true - using symbolic constants is preferred over numeric ones. > Where does this recommendation come from? http://lkml.kernel.org/r/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ at mail.gmail.com which is: https://marc.info/?l=linux-arm-kernel&m=147017161402213&w=2 Subject: Please don't replace numeric parameter like 0444 with macro From: Linus Torvalds Date: 2016-08-02 20:58:29 [ So I answered similarly to another patch, but I'll just re-iterate and change the subject line so that it stands out a bit from the millions of actual patches ] On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek wrote: > > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR | > S_IRCRP | S_IROTH (*). Please don't do this. Absolutely. It's *much* easier to parse and understand the octal numbers, while the symbolic macro names are just random line noise and hard as hell to understand. You really have to think about it. So we should rather go the other way: convert existing bad symbolic permission bit macro use to just use the octal numbers. The symbolic names are good for the *other* bits (ie sticky bit, and the inode mode _type_ numbers etc), but for the permission bits, the symbolic names are just insane crap. Nobody sane should ever use them. Not in the kernel, not in user space. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbdAYCXn (ORCPT ); Tue, 24 Jan 2017 21:23:43 -0500 Received: from smtprelay0129.hostedemail.com ([216.40.44.129]:49448 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbdAYCXl (ORCPT ); Tue, 24 Jan 2017 21:23:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:196:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1622:1711:1730:1747:1777:1792:2393:2525:2553:2561:2564:2682:2685:2692:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4605:5007:6671:6691:7514:7522:7576:7875:7974:8985:9025:9545:10004:10400:10848:11232:11256:11257:11658:11914:12043:12262:12438:12555:12679:12682:12740:12760:12783:12895:12986:13007:13069:13161:13229:13311:13357:13439:13845:14096:14097:14181:14659:14721:14777:14849:21080:21324:21433:21451:30030:30034:30051:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: hour37_2c0fb4d2d954 X-Filterd-Recvd-Size: 2771 Message-ID: <1485311017.12563.48.camel@perches.com> Subject: Re: [PATCH 1/2] staging: lustre: libcfs: use octal permissions From: Joe Perches To: "Dilger, Andreas" , Ernestas Kulik Cc: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Tue, 24 Jan 2017 18:23:37 -0800 In-Reply-To: <715A0C57-2EE3-486E-A5DE-E372366B6BE8@intel.com> References: <20170124174050.6534-1-ernestas.kulik@gmail.com> <715A0C57-2EE3-486E-A5DE-E372366B6BE8@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-24 at 22:22 +0000, Dilger, Andreas wrote: > On Jan 24, 2017, at 09:40, Ernestas Kulik wrote: > > > > Using octal permissions instead of symbolic ones is preferred. > > Typically the reverse is true - using symbolic constants is preferred over numeric ones. > Where does this recommendation come from? http://lkml.kernel.org/r/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com which is: https://marc.info/?l=linux-arm-kernel&m=147017161402213&w=2 Subject: Please don't replace numeric parameter like 0444 with macro From: Linus Torvalds Date: 2016-08-02 20:58:29 [ So I answered similarly to another patch, but I'll just re-iterate and change the subject line so that it stands out a bit from the millions of actual patches ] On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek wrote: > > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR | > S_IRCRP | S_IROTH (*). Please don't do this. Absolutely. It's *much* easier to parse and understand the octal numbers, while the symbolic macro names are just random line noise and hard as hell to understand. You really have to think about it. So we should rather go the other way: convert existing bad symbolic permission bit macro use to just use the octal numbers. The symbolic names are good for the *other* bits (ie sticky bit, and the inode mode _type_ numbers etc), but for the permission bits, the symbolic names are just insane crap. Nobody sane should ever use them. Not in the kernel, not in user space.