From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 0/2] dmaengine: Add DW AXI DMAC driver
Date: Wed, 25 Jan 2017 18:41:15 +0200 [thread overview]
Message-ID: <1485362475.2133.329.camel@linux.intel.com> (raw)
In-Reply-To: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com>
On Wed, 2017-01-25@18:34 +0300, Eugeniy Paltsev wrote:
> This patch series add support for the DW AXI DMAC controller.
>
> DW AXI DMAC is a part of upcoming development board from Synopsys.
>
> In this driver implementation only DMA_MEMCPY and DMA_SG transfers
> are supported.
>
> Changes for v0:
> ?* Switch to virt-dma API (according to previous RFC)
> ?* Small fixies according to previous RFC
Yeah, seems you didn't address some of the comments and didn't comment
why...
> ?* Add DT bindings
>
> Eugeniy Paltsev (2):
> ? dt-bindings: Document the Synopsys DW AXI DMA bindings
> ? dmaengine: Add DW AXI DMAC driver
>
> ?.../devicetree/bindings/dma/snps,axi-dw-dmac.txt???|???33 +
> ?drivers/dma/Kconfig????????????????????????????????|????8 +
> ?drivers/dma/Makefile???????????????????????????????|????1 +
> ?drivers/dma/axi_dma_platform.c?????????????????????| 1060
> ++++++++++++++++++++
This surprises me. I would expect more then 100+ LOC reduction when
switched to virt-dma API. Can you double check that you are using it
effectively?
> ?drivers/dma/axi_dma_platform.h?????????????????????|??124 +++
> ?drivers/dma/axi_dma_platform_reg.h?????????????????|??189 ++++
> ?6 files changed, 1415 insertions(+)
> ?create mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw-
> dmac.txt
> ?create mode 100644 drivers/dma/axi_dma_platform.c
> ?create mode 100644 drivers/dma/axi_dma_platform.h
> ?create mode 100644 drivers/dma/axi_dma_platform_reg.h
>
--
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
dmaengine@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH 0/2] dmaengine: Add DW AXI DMAC driver
Date: Wed, 25 Jan 2017 18:41:15 +0200 [thread overview]
Message-ID: <1485362475.2133.329.camel@linux.intel.com> (raw)
In-Reply-To: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com>
On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote:
> This patch series add support for the DW AXI DMAC controller.
>
> DW AXI DMAC is a part of upcoming development board from Synopsys.
>
> In this driver implementation only DMA_MEMCPY and DMA_SG transfers
> are supported.
>
> Changes for v0:
> * Switch to virt-dma API (according to previous RFC)
> * Small fixies according to previous RFC
Yeah, seems you didn't address some of the comments and didn't comment
why...
> * Add DT bindings
>
> Eugeniy Paltsev (2):
> dt-bindings: Document the Synopsys DW AXI DMA bindings
> dmaengine: Add DW AXI DMAC driver
>
> .../devicetree/bindings/dma/snps,axi-dw-dmac.txt | 33 +
> drivers/dma/Kconfig | 8 +
> drivers/dma/Makefile | 1 +
> drivers/dma/axi_dma_platform.c | 1060
> ++++++++++++++++++++
This surprises me. I would expect more then 100+ LOC reduction when
switched to virt-dma API. Can you double check that you are using it
effectively?
> drivers/dma/axi_dma_platform.h | 124 +++
> drivers/dma/axi_dma_platform_reg.h | 189 ++++
> 6 files changed, 1415 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw-
> dmac.txt
> create mode 100644 drivers/dma/axi_dma_platform.c
> create mode 100644 drivers/dma/axi_dma_platform.h
> create mode 100644 drivers/dma/axi_dma_platform_reg.h
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-01-25 16:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:34 [PATCH 0/2] dmaengine: Add DW AXI DMAC driver Eugeniy Paltsev
2017-01-25 15:34 ` Eugeniy Paltsev
2017-01-25 15:34 ` [PATCH 1/2] dt-bindings: Document the Synopsys DW AXI DMA bindings Eugeniy Paltsev
2017-01-25 15:34 ` Eugeniy Paltsev
2017-01-25 15:34 ` Eugeniy Paltsev
2017-01-30 20:08 ` Rob Herring
2017-01-30 20:08 ` Rob Herring
2017-01-30 20:08 ` Rob Herring
2017-01-25 15:34 ` [PATCH 2/2] dmaengine: Add DW AXI DMAC driver Eugeniy Paltsev
2017-01-25 15:34 ` Eugeniy Paltsev
2017-01-25 15:34 ` Eugeniy Paltsev
2017-01-25 16:49 ` kbuild test robot
2017-01-25 16:49 ` kbuild test robot
2017-01-25 16:49 ` kbuild test robot
2017-01-25 17:25 ` Andy Shevchenko
2017-01-25 17:25 ` Andy Shevchenko
2017-01-25 17:25 ` Andy Shevchenko
2017-02-09 13:58 ` Eugeniy Paltsev
2017-02-09 13:58 ` Eugeniy Paltsev
2017-02-09 20:52 ` Andy Shevchenko
2017-02-09 20:52 ` Andy Shevchenko
2017-02-10 6:06 ` Vinod Koul
2017-02-10 6:06 ` Vinod Koul
2017-02-10 6:06 ` Vinod Koul
2017-02-10 8:23 ` Alexey Brodkin
2017-02-10 8:23 ` Alexey Brodkin
2017-02-10 8:23 ` Alexey Brodkin
2017-01-25 16:41 ` Andy Shevchenko [this message]
2017-01-25 16:41 ` [PATCH 0/2] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485362475.2133.329.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.