diff for duplicates of <1485369563.7117.81.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index a9916ff..e82f7e0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Giuseppe, -On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote: +On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote: > Hello Alexey > > Sorry for my late reply. In that case, I think that the stmmac @@ -42,20 +42,20 @@ index a276a32d57f2..f4b67dc7d530 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv) -????????int interface = priv->plat->interface; -? -????????if (priv->dma_cap.pcs) { --???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) || --???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) || --???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) || --???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) { --???????????????????????netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); --???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII; --???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) { -+???????????????if (interface == PHY_INTERFACE_MODE_SGMII) { -????????????????????????netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); -????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII; -????????????????} + int interface = priv->plat->interface; + + if (priv->dma_cap.pcs) { +- if ((interface == PHY_INTERFACE_MODE_RGMII) || +- (interface == PHY_INTERFACE_MODE_RGMII_ID) || +- (interface == PHY_INTERFACE_MODE_RGMII_RXID) || +- (interface == PHY_INTERFACE_MODE_RGMII_TXID)) { +- netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); +- priv->hw->pcs = STMMAC_PCS_RGMII; +- } else if (interface == PHY_INTERFACE_MODE_SGMII) { ++ if (interface == PHY_INTERFACE_MODE_SGMII) { + netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); + priv->hw->pcs = STMMAC_PCS_SGMII; + } --------------------------->8-------------------------- > Also I wonder if, other version of the stmmac worked on this platform diff --git a/a/content_digest b/N1/content_digest index 2e52ff6..ae773a2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,23 @@ "ref\01478189833.4072.65.camel@synopsys.com\0" "ref\0a1f114cc-6120-154c-a3f7-3e0389d38e36@st.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0stmmac: GMAC_RGSMIIIS reports bogus values\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: stmmac: GMAC_RGSMIIIS reports bogus values\0" "Date\0Wed, 25 Jan 2017 18:39:24 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0peppe.cavallaro@st.com <peppe.cavallaro@st.com>\0" + "Cc\0manabian@gmail.com <manabian@gmail.com>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + fabrice.gasnier@st.com <fabrice.gasnier@st.com> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + alexandre.torgue@gmail.com <alexandre.torgue@gmail.com> + preid@electromag.com.au <preid@electromag.com.au> + netdev@vger.kernel.org <netdev@vger.kernel.org> + Vineet Gupta <Vineet.Gupta1@synopsys.com> + " davem@davemloft.net <davem@davemloft.net>\0" "\00:1\0" "b\0" "Hi Giuseppe,\n" "\n" - "On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote:\n" + "On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote:\n" "> Hello Alexey\n" "> \n" "> Sorry for my late reply. In that case, I think that the stmmac\n" @@ -50,20 +59,20 @@ "--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "@@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)\n" - "????????int interface = priv->plat->interface;\n" - "?\n" - "????????if (priv->dma_cap.pcs) {\n" - "-???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" - "-???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" - "-???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" - "-???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" - "-???????????????????????netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" - "-???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII;\n" - "-???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "+???????????????if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "????????????????????????netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" - "????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII;\n" - "????????????????}\n" + "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240int interface = priv->plat->interface;\n" + "\302\240\n" + "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (priv->dma_cap.pcs) {\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_RGMII;\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" + "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_SGMII;\n" + "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "--------------------------->8--------------------------\n" "\n" "> Also I wonder if, other version of the stmmac worked on this platform\n" @@ -75,4 +84,4 @@ "\n" -Alexey -dca0f073df14d62d667800515387fc15a73edf6e4cba45b58c57d535a6a51a73 +b725525d51e8110b79d84d5db4b2778aa450c2d52cb1ed45811bceb6209cd78d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.