From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other. Date: Thu, 26 Jan 2017 12:09:30 +0100 Message-ID: <1485428970.32103.143.camel@citrix.com> References: <1480943129-20524-1-git-send-email-andr2000@gmail.com> <1480943129-20524-2-git-send-email-andr2000@gmail.com> <20170124191352.GA20813@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3788070637294216040==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Oleksandr Andrushchenko , Konrad Rzeszutek Wilk Cc: lars.kurth@citrix.com, iurii.konovalenko@globallogic.com, vlad.babchuk@gmail.com, ian.jackson@eu.citrix.com, oleksandr.dmytryshyn@globallogic.com, tim@xen.org, julien.grall@arm.com, andrii.anisov@gmail.com, olekstysh@gmail.com, embedded-pv-devel@lists.xenproject.org, al1img@gmail.com, david.vrabel@citrix.com, JBeulich@suse.com, xen-devel@lists.xenproject.org, joculator@gmail.com List-Id: xen-devel@lists.xenproject.org --===============3788070637294216040== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-ILXRtazTSdNzTXxlrzi4" --=-ILXRtazTSdNzTXxlrzi4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-01-26 at 12:02 +0200, Oleksandr Andrushchenko wrote: > Hi, Konrad! >=20 > First of all thank you very much for the valuable comments >=20 > and your time! >=20 > The number of changes (mostly in description) is going to >=20 > be huge, so do you think I can publish something like >=20 > "RFC v16" so we can discuss the updated patch? >=20 Konrad's call, but why you want to introduce the 'RFC' tag now? I'd just go with v16... > On 01/24/2017 09:13 PM, Konrad Rzeszutek Wilk wrote: > > On Mon, Dec 05, 2016 at 03:05:29PM +0200, Oleksandr Andrushchenko > > wrote: > > >=C2=A0 > > > + * Example for the frontend running in domain 5, instance of the > > > driver > > > + * in the front is 0 (single or first PV driver), device id 2, > > > + * first stream (0): > > > + * /local/domain//device/vsnd// > > > + *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0device//stream//type =3D "p" > > > + * /local/domain/5/device/vsnd/0/device/2/stream/0/type =3D "p" > > Why do you need 'device' ? > just for clarity: the hierarchy of the sound driver would > be that a device may have multiple different streams. > So, from readability POV I would still have "device" in place > =C2=A0From xenstore documentation: "Data should generally be > human-readable for ease of management and debugging " > I assume this also applies to the structure as well > Perhaps: =C2=A0/local/domain//device/vsnd//dev-/stream= -/... > > Could not this be: > >=20 > > /local/domain/5/device/vsnd/0/2/stream/0/type =3D "p" ? > then one has to know that "2" stands for device. > see above, I would keep "device" here > > >=20 =C2=A0/local/domain/5/device/vsnd/0/dev-2/stream-0/type =3D "p" Or, with no '-': =C2=A0/local/domain/5/device/vsnd/0/dev2/stream0/type =3D "p" Just my 2 cents... Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-ILXRtazTSdNzTXxlrzi4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYidjrAAoJEBZCeImluHPuwJQP/1nLri2xcY7BBotdxPbIVR5n AbqYrg1CVfbViEYGTn0Jef2q9+0oJ5JS2DatxBa2CxHFA8HKnOZwaZ3UNkbNR5FZ suGBGdP0nbErbieJyQ3xlo/1BdyNPhrjhXJ/1ucZ2nG4oUOQwTevMTUDMJT/sT8i Okteh3TVcHkX+hweetBIG3Qcgccazh5ktafGryyUXj3eQpMuePfZ5Q0dF0LVUPhX OSMqGqGayGNkU2YN+ZMqTt2QVf38JtzVL1SYIQ6fikyBb0WfoQKPxUo85TM5qCaf 7UA3TipT6eOtYQg7KzqGBtYuIiyg+5R4kTfV/Cm8+VTEzQ1DynidOVgUM9ID0bp2 YNt5Hh9uxUw2rSiZ/b7oTRhhBT4TGkrIu29fDQnEWjSl0rUhozUs7qzt9PAD5i4d r0EGA69IhCYNpdUwDRmqvjSwZafJ/nU9Y+KeQTjrLEgcMODU4GHGLr/RxahxuGfj sK4cYOqLib5BkvzgiewN/ml8Mdnou2vUzkUQaEqhEHduAcV+Vp4v7PIxmvNHPCwD hs0Xj5HRUuFrKWNHMQ3DKVPZkjPl9YIEkJ5T6oazFxL80pCuNT82QJnzG0SBG+pp /S27yufelnxzMsEHrefisIDU8oz9T0oKxBJPQ0jUYnOLIyO0uAWdLWTWk7V7gD3g aFNtT1sEavSD5rfXaPSG =e+ot -----END PGP SIGNATURE----- --=-ILXRtazTSdNzTXxlrzi4-- --===============3788070637294216040== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============3788070637294216040==--