From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other. Date: Thu, 26 Jan 2017 12:54:52 +0100 Message-ID: <1485431692.32103.152.camel@citrix.com> References: <1480943129-20524-1-git-send-email-andr2000@gmail.com> <1480943129-20524-2-git-send-email-andr2000@gmail.com> <20170124191352.GA20813@char.us.oracle.com> <1485428970.32103.143.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5778419803508807451==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Oleksandr Andrushchenko , Konrad Rzeszutek Wilk Cc: lars.kurth@citrix.com, iurii.konovalenko@globallogic.com, vlad.babchuk@gmail.com, ian.jackson@eu.citrix.com, oleksandr.dmytryshyn@globallogic.com, tim@xen.org, julien.grall@arm.com, andrii.anisov@gmail.com, olekstysh@gmail.com, embedded-pv-devel@lists.xenproject.org, al1img@gmail.com, david.vrabel@citrix.com, JBeulich@suse.com, xen-devel@lists.xenproject.org, joculator@gmail.com List-Id: xen-devel@lists.xenproject.org --===============5778419803508807451== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-ejglGz7vBz7ORQBIsriL" --=-ejglGz7vBz7ORQBIsriL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-01-26 at 13:23 +0200, Oleksandr Andrushchenko wrote: > On 01/26/2017 01:09 PM, Dario Faggioli wrote: > > > On 01/24/2017 09:13 PM, Konrad Rzeszutek Wilk wrote: > > > > On Mon, Dec 05, 2016 at 03:05:29PM +0200, Oleksandr > > > > Andrushchenko wrote: > > > > > + * Example for the frontend running in domain 5, instance of > > > > > the > > > > > driver > > > > > + * in the front is 0 (single or first PV driver), device id > > > > > 2, > > > > > + * first stream (0): > > > > > + * /local/domain//device/vsnd// > > > > > + *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0device/<= dev_id>/stream//type =3D "p" > > > > > + * /local/domain/5/device/vsnd/0/device/2/stream/0/type =3D > > > > > "p" > > > > Why do you need 'device' ? > > > > Could not this be: > > > >=20 > > > > /local/domain/5/device/vsnd/0/2/stream/0/type =3D "p" ? > > > then one has to know that "2" stands for device. > > > see above, I would keep "device" here > > =C2=A0 /local/domain/5/device/vsnd/0/dev-2/stream-0/type =3D "p" > >=20 > > Or, with no '-': > >=20 > > =C2=A0 /local/domain/5/device/vsnd/0/dev2/stream0/type =3D "p" > >=20 > > Just my 2 cents... > 1. Well, the only reason I have "device" here is for clarity > and consistency: sound card owns PCM devices, PCM device owns > streams > We could probably have "pcm-dev" instead of "device" here, > so we do not collide with xen device. > Sure. Or maybe even just 'pcm' (matter of taste, to large extent). > 2. "dev-%d" or "dev%d", "stream-%d" or "stream%d" > IMO, we already have indices employed in xenstore, > e.g. "domain/5", not "domain-5" or "domain5" > So, is the PCM device in question any different from domain > from this POV? To me - not, so this is why I use "device/%d" >=20 True. Well, actually, have both. For instance, blkif, when multiqueue is available are enabled, looks like this: =C2=A0/local/domain/1/device/vbd/0/multi-queue-num-queues =3D "2" =C2=A0/local/domain/1/device/vbd/0/queue-0 =3D "" =C2=A0/local/domain/1/device/vbd/0/queue-0/ring-ref =3D "" =C2=A0/local/domain/1/device/vbd/0/queue-0/event-channel =3D "" =C2=A0/local/domain/1/device/vbd/0/queue-1 =3D "" =C2=A0/local/domain/1/device/vbd/0/queue-1/ring-ref =3D "" =C2=A0/local/domain/1/device/vbd/0/queue-1/event-channel =3D "" So, while I after all thing I agree with you on point 1) (i.e., on having device, or pcm-dev, or pcm, the latter being my prefernce), I think it would be ok to manage streams like blkif manages queues, and hence using stream-0, stream-1, etc. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-ejglGz7vBz7ORQBIsriL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYieOMAAoJEBZCeImluHPuTpcP/j9Rkf7rbGc1FzV9uYxGfVrh MOTBf+fNHGBQLb3ZBk9IZlWUc1+QWGKu1QjFy7HimmdBKaRe3cFGel+ooKxCfAm0 OeVp12O7uJLAw5+Jr8cXR6nzMGNpkgHcVms/GMOAm4eMiWiTDBNFy5nvdXuYvhzI h/NmH/rD2RZ1uNFhE8d4R05UmpnSoxkvZaZhIFjXvnecAoogFY9WAEd68TnsdxEL DEJUHtRMQLu9nTB9A6qKx3ob/95XeJSdcZjtzs+9TYxiHmieTDMgOIilU76oha5d IGNmrhGAxwpBPY/YYMllwBlIPX6NcvYwBlQqs2QlXeQp9YECazpUqMNKDoi5ZrtB ByzCpLPJkorMtTbTpgvndOggcQ5iFkLt1C83vfEoiaPnTnt0qWOVQJI6PHm846zX CkoEbLHxdGcvCYS4OvwN5LgAAdecPBcoQOsq1FgvXFfaxPR7Tkn+wQQVBxyzEQaN 7EkIggMGuCJ2DYhvO9WOKEMa8aWqBMRhoHvLfcKCgKUZ7tZz4ppC1t3h76kgZcji Z2dOPTWx7Ikvo8iO7f2KcM80jhqd02o/iiUl/ECU8QnjwraCQ0VeN3TzqiD3BE34 UAW/Yr4T0NlDdXR1U7qJ3xQSyO6r8FMBy4yviasDGvklfCj4cXuM+A1YaeGTABd4 H4KcEF0CEWEvj9vBkp6M =MhiM -----END PGP SIGNATURE----- --=-ejglGz7vBz7ORQBIsriL-- --===============5778419803508807451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5778419803508807451==--