From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: IPv6-UDP 0x0000 checksum
Date: Thu, 26 Jan 2017 16:32:21 +0100 [thread overview]
Message-ID: <1485444741.14760.12.camel@sipsolutions.net> (raw)
In-Reply-To: <1485444276.5145.133.camel@edumazet-glaptop3.roam.corp.google.com> (sfid-20170126_162439_678922_DB33D27A)
On Thu, 2017-01-26 at 07:24 -0800, Eric Dumazet wrote:
> On Thu, 2017-01-26 at 15:49 +0100, Johannes Berg wrote:
>
> > Unfortunately, I haven't been able to actually test this yet. I
> > also
> > didn't find the code that would drop frames with CSUM 0 either, so
> > I'm
> > thinking - for now - that if all the csum handling is skipped,
> > dropping
> > 0 csum frames would also be, and then we'd accept a frame we should
> > actually have dropped.
> >
> > I'll go test this I guess :)
> >
> > Any pointers to where 0 csum frames are dropped?
>
> Probably in udp6_csum_init()
Well, now that I see that, I see that they're actually valid in some
circumstances. Oops. :)
Will need to revisit, and check how we set no_check6_rx, etc.
johannes
prev parent reply other threads:[~2017-01-26 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 13:27 IPv6-UDP 0x0000 checksum Johannes Berg
2017-01-26 13:44 ` Eric Dumazet
2017-01-26 13:49 ` Johannes Berg
2017-01-26 14:45 ` Eric Dumazet
2017-01-26 14:45 ` Eric Dumazet
2017-01-26 14:49 ` Johannes Berg
2017-01-26 14:49 ` Johannes Berg
2017-01-26 15:24 ` Eric Dumazet
2017-01-26 15:24 ` Eric Dumazet
2017-01-26 15:27 ` Eric Dumazet
2017-01-26 15:27 ` Eric Dumazet
2017-01-26 15:36 ` Johannes Berg
2017-01-26 15:36 ` Johannes Berg
2017-01-26 15:32 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485444741.14760.12.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.