All of lore.kernel.org
 help / color / mirror / Atom feed
From: johannes@sipsolutions.net (Johannes Berg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] modifying initializers with spatch?
Date: Thu, 26 Jan 2017 16:52:31 +0100	[thread overview]
Message-ID: <1485445951.14760.16.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1701261644140.3109@hadrien>


> The problem is that Coccinelle lets you put fewer field initializers
> than
> are actually available.??The reasoning is that they are optional for
> fields, and the user doesn't really know how many will be present in
> each
> case.??{} is the degenerate case where none are mentioned.??But that
> should not apply to your case, 1) because you are removing the
> braces, and
> 2) because you aren't doing field initializations anyway.??I'll have
> to look into it.

Ok, thanks.

I actually had a separate thought, that I could perhaps do something
like


{
... when != { ... }
T x = {
-  .field = E,
};
... when != S
    when any
++  x.field = E;


To get rid of all the initializers, but (as I'm still on the phone) I
haven't tried it yet :)

Btw, how was the ++ supposed to work? I had to run this more than once
to actually make it catch multiple instances of = {0}. Also, in the
case above, even if it works, the order of initializations might be
inverted if I run the spatch multiple times, so not sure I should do
that.

johannes

  reply	other threads:[~2017-01-26 15:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 12:28 [Cocci] modifying initializers with spatch? Johannes Berg
2017-01-26 13:17 ` Julia Lawall
2017-01-26 13:32   ` Johannes Berg
2017-01-26 14:20     ` Julia Lawall
2017-01-26 14:28       ` Johannes Berg
2017-01-26 15:47         ` Julia Lawall
2017-01-26 15:52           ` Johannes Berg [this message]
2017-01-26 15:57             ` Julia Lawall
2017-01-27 21:43               ` Johannes Berg
2017-01-27 21:52                 ` Julia Lawall
2017-01-27 22:03                   ` Johannes Berg
2017-01-27 22:09                     ` Julia Lawall
2017-01-27 22:23                       ` Johannes Berg
2017-01-27 23:02                       ` Johannes Berg
2017-01-27 23:20                         ` Johannes Berg
2017-01-28  6:47                           ` Julia Lawall
2017-01-28  8:20                             ` Johannes Berg
2017-01-27  7:09             ` Julia Lawall
2017-01-27  8:55               ` Johannes Berg
2017-01-27 13:11                 ` Julia Lawall
2017-01-27 16:13                   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485445951.14760.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.