diff for duplicates of <1485455329.2540.7.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 43ccb7f..ad372e2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,17 @@ On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > Hi all, -> +>=20 > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to embedded as the first thing into their request-private data, > similar to how we handle NVMe passthrough commands. -> +>=20 > To support this I've added support for that the private data after > request structure to the legacy request path instead, so that it can > be treated the same way as the blk-mq path. Compare to the current > scsi_cmnd allocator that actually is a major simplification. -> +>=20 > Changes since V1: > - fix handling of a NULL sense pointer in __scsi_execute > - clean up handling of the flush flags in the block layer and MD @@ -21,16 +21,34 @@ Hello Christoph, Thanks for having fixed the NULL pointer issue I had reported for v1. However, if I try to run my srp-test testsuite on top of your -hch-block/block-pc-refactor branch (commit ID a07dc3521034) merged +hch-block/block-pc-refactor=A0branch (commit ID a07dc3521034) merged with v4.10-rc5 the following appears on the console: [ 707.317403] BUG: scheduling while atomic: fio/9073/0x00000003 [ 707.317404] 1 lock held by fio/9073: -[ 707.317404] #0: (rcu_read_lock){......}, at: [<ffffffff8132618e>] __blk_mq_run_hw_queue+0xde/0x1c0 -[ 707.317409] Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_user uio target_core_pscsi target_core_file ib_srpt target_core_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_intel hid_generic pcbc usbhid iTCO_wdt tg3 aesni_intel -[ 707.317445] ptp iTCO_vendor_support aes_x86_64 crypto_simd pps_core glue_helper dcdbas ipmi_si ipmi_devintf libphy devlink lpc_ich cryptd pcspkr ipmi_msghandler mfd_core fjes mei_me tpm_tis button tpm_tis_core shpchp mei tpm wmi mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod cdrom drm ehci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4 -[ 707.317469] CPU: 6 PID: 9073 Comm: fio Tainted: G W 4.10.0-rc5-dbg+ #1 -[ 707.317470] Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014 +[ 707.317404] #0: (rcu_read_lock){......}, at: [<ffffffff8132618e>] __bl= +k_mq_run_hw_queue+0xde/0x1c0 +[ 707.317409] Modules linked in: dm_service_time ib_srp scsi_transport_srp= + target_core_user uio target_core_pscsi target_core_file ib_srpt target_cor= +e_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQ= +UERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_c= +onntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject= +_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter = +ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib= +_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_= +edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm= +_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel g= +hash_clmulni_intel hid_generic pcbc usbhid iTCO_wdt tg3 aesni_intel +[ 707.317445] ptp iTCO_vendor_support aes_x86_64 crypto_simd pps_core glu= +e_helper dcdbas ipmi_si ipmi_devintf libphy devlink lpc_ich cryptd pcspkr i= +pmi_msghandler mfd_core fjes mei_me tpm_tis button tpm_tis_core shpchp mei = +tpm wmi mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgb= +lt fb_sys_fops ttm sr_mod cdrom drm ehci_pci ehci_hcd usbcore usb_common sg= + dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4 +[ 707.317469] CPU: 6 PID: 9073 Comm: fio Tainted: G W 4.10.0-= +rc5-dbg+ #1 +[ 707.317470] Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 1= +1/17/2014 [ 707.317470] Call Trace: [ 707.317473] dump_stack+0x68/0x93 [ 707.317475] __schedule_bug+0x5b/0x80 @@ -57,4 +75,4 @@ with v4.10-rc5 the following appears on the console: [ 707.317537] SyS_io_submit+0xb/0x10 [ 707.317539] entry_SYSCALL_64_fastpath+0x18/0xad -Bart. +Bart.= diff --git a/a/content_digest b/N1/content_digest index 58c7e16..e724e65 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,18 +14,18 @@ "b\0" "On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:\n" "> Hi all,\n" - "> \n" + ">=20\n" "> this series splits the support for SCSI passthrough commands from the\n" "> main struct request used all over the block layer into a separate\n" "> scsi_request structure that drivers that want to support SCSI passthough\n" "> need to embedded as the first thing into their request-private data,\n" "> similar to how we handle NVMe passthrough commands.\n" - "> \n" + ">=20\n" "> To support this I've added support for that the private data after\n" "> request structure to the legacy request path instead, so that it can\n" "> be treated the same way as the blk-mq path. Compare to the current\n" "> scsi_cmnd allocator that actually is a major simplification.\n" - "> \n" + ">=20\n" "> Changes since V1:\n" "> - fix handling of a NULL sense pointer in __scsi_execute\n" "> - clean up handling of the flush flags in the block layer and MD\n" @@ -35,16 +35,34 @@ "\n" "Thanks for having fixed the NULL pointer issue I had reported for v1.\n" "However, if I try to run my srp-test testsuite on top of your\n" - "hch-block/block-pc-refactor\302\240branch (commit ID a07dc3521034) merged\n" + "hch-block/block-pc-refactor=A0branch (commit ID a07dc3521034) merged\n" "with v4.10-rc5 the following appears on the console:\n" "\n" "[ 707.317403] BUG: scheduling while atomic: fio/9073/0x00000003\n" "[ 707.317404] 1 lock held by fio/9073:\n" - "[ 707.317404] #0: (rcu_read_lock){......}, at: [<ffffffff8132618e>] __blk_mq_run_hw_queue+0xde/0x1c0\n" - "[ 707.317409] Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_user uio target_core_pscsi target_core_file ib_srpt target_core_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_intel hid_generic pcbc usbhid iTCO_wdt tg3 aesni_intel\n" - "[ 707.317445] ptp iTCO_vendor_support aes_x86_64 crypto_simd pps_core glue_helper dcdbas ipmi_si ipmi_devintf libphy devlink lpc_ich cryptd pcspkr ipmi_msghandler mfd_core fjes mei_me tpm_tis button tpm_tis_core shpchp mei tpm wmi mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod cdrom drm ehci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4\n" - "[ 707.317469] CPU: 6 PID: 9073 Comm: fio Tainted: G W 4.10.0-rc5-dbg+ #1\n" - "[ 707.317470] Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014\n" + "[ 707.317404] #0: (rcu_read_lock){......}, at: [<ffffffff8132618e>] __bl=\n" + "k_mq_run_hw_queue+0xde/0x1c0\n" + "[ 707.317409] Modules linked in: dm_service_time ib_srp scsi_transport_srp=\n" + " target_core_user uio target_core_pscsi target_core_file ib_srpt target_cor=\n" + "e_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQ=\n" + "UERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_c=\n" + "onntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject=\n" + "_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter =\n" + "ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib=\n" + "_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_=\n" + "edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm=\n" + "_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel g=\n" + "hash_clmulni_intel hid_generic pcbc usbhid iTCO_wdt tg3 aesni_intel\n" + "[ 707.317445] ptp iTCO_vendor_support aes_x86_64 crypto_simd pps_core glu=\n" + "e_helper dcdbas ipmi_si ipmi_devintf libphy devlink lpc_ich cryptd pcspkr i=\n" + "pmi_msghandler mfd_core fjes mei_me tpm_tis button tpm_tis_core shpchp mei =\n" + "tpm wmi mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgb=\n" + "lt fb_sys_fops ttm sr_mod cdrom drm ehci_pci ehci_hcd usbcore usb_common sg=\n" + " dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4\n" + "[ 707.317469] CPU: 6 PID: 9073 Comm: fio Tainted: G W 4.10.0-=\n" + "rc5-dbg+ #1\n" + "[ 707.317470] Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 1=\n" + "1/17/2014\n" "[ 707.317470] Call Trace:\n" "[ 707.317473] dump_stack+0x68/0x93\n" "[ 707.317475] __schedule_bug+0x5b/0x80\n" @@ -71,6 +89,6 @@ "[ 707.317537] SyS_io_submit+0xb/0x10\n" "[ 707.317539] entry_SYSCALL_64_fastpath+0x18/0xad\n" "\n" - Bart. + Bart.= -3120657b08176dce711e39c5cea9c9f72e8cb75c8c33fcd03c75fab92dd8d191 +e5e6c28b9b1aa5975a99611ea7daf6867552bd8883442ffb1a49e99236c8050b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.