All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <1485467235.2540.14.camel@sandisk.com>

diff --git a/a/1.txt b/N1/1.txt
index f2f01dc..381369d 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -3,16 +3,16 @@ On Thu, 2017-01-26 at 14:12 -0700, Jens Axboe wrote:
 > > On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote:
 > > > Your call path has blk_get_request() in it, I don't have
 > > > that in my tree. Is it passing in the right mask?
-> > 
+> >=20
 > > Hello Jens,
-> > 
+> >=20
 > > There is only one blk_get_request() call in drivers/md/dm-mpath.c
 > > and it looks as follows:
-> > 
-> >  	clone = blk_get_request(bdev_get_queue(bdev),
+> >=20
+> >  	clone =3D blk_get_request(bdev_get_queue(bdev),
 > > 			rq->cmd_flags | REQ_NOMERGE,
 > > 			GFP_ATOMIC);
-> 
+>=20
 > Yeah, I found it in the dm patch. Looks fine to me, since
 > blk_mq_alloc_request() checks for __GFP_DIRECT_RECLAIM. Weird, it all
 > looks fine to me. Are you sure you tested with the patch? Either that,
@@ -28,12 +28,28 @@ stack appeared:
 
 BUG: unable to handle kernel NULL pointer dereference at 000000000000005c
 IP: blk_mq_sched_get_request+0x310/0x350
-PGD 34bd9c067 
-PUD 346b37067 
-PMD 0 
+PGD 34bd9c067=20
+PUD 346b37067=20
+PMD 0=20
 
 Oops: 0000 [#1] SMP
-Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_user uio target_core_pscsi target_core_file ib_srpt target_core_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_intel pcbc aesni_intel aes_x86_64 tg3 iTCO_wdt crypto_simd dcdbas iTCO_vendor_support ptp glue_helper ipmi_si cryptd ipmi_devintf pps_core fjes devlink ipmi_msghandler pcspkr libphy tpm_tis tpm_tis_core tpm button mei_me lpc_ich wmi mei mfd_core shpchp hid_generic usbhid mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod drm cdrom ehci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4
+Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_us=
+er uio target_core_pscsi target_core_file ib_srpt target_core_iblock target=
+_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_m=
+asquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 n=
+f_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp=
+ tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables ipta=
+ble_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs =
+ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core =
+x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqb=
+ypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_in=
+tel pcbc aesni_intel aes_x86_64 tg3 iTCO_wdt crypto_simd dcdbas iTCO_vendor=
+_support ptp glue_helper ipmi_si cryptd ipmi_devintf pps_core fjes devlink =
+ipmi_msghandler pcspkr libphy tpm_tis tpm_tis_core tpm button mei_me lpc_ic=
+h wmi mei mfd_core shpchp hid_generic usbhid mgag200 i2c_algo_bit drm_kms_h=
+elper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod drm cdrom eh=
+ci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi=
+_dh_emc scsi_dh_alua autofs4
 CPU: 0 PID: 9231 Comm: fio Not tainted 4.10.0-rc4-dbg+ #1
 Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014
 task: ffff88034c8c3140 task.stack: ffffc90005698000
@@ -44,7 +60,8 @@ RDX: 000000000000001f RSI: ffff8803507bdcf8 RDI: 000000000000001f
 RBP: ffffc9000569bb00 R08: 0000000000000001 R09: 0000000000000000
 R10: 0000000000000001 R11: 0000000000000000 R12: ffffc9000569bb18
 R13: 000000000000c801 R14: 0000000000000000 R15: 0000000000000000
-FS:  00007f65ca054700(0000) GS:ffff88046f200000(0000) knlGS:0000000000000000
+FS:  00007f65ca054700(0000) GS:ffff88046f200000(0000) knlGS:000000000000000=
+0
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 000000000000005c CR3: 000000034b0ed000 CR4: 00000000001406f0
 Call Trace:
@@ -70,34 +87,44 @@ RDX: 00007f65a404f158 RSI: 0000000000000001 RDI: 00007f65f6bfd000
 RBP: 0000000000000815 R08: 0000000000000001 R09: 00007f65a404e3e0
 R10: 00007f65a4040000 R11: 0000000000000202 R12: 00000000000006d0
 R13: 00007f65a404e930 R14: 0000000000001000 R15: 0000000000000830
-Code: 67 ff ff ff e9 80 fe ff ff 48 89 df e8 ba c4 fe ff 31 c9 e9 60 ff ff ff 44 89 ee 4c 89 e7 e8 c8 6d ff ff 48 89 c1 49 8b 44 24 18 <48> 63 51 5c 48 8b 80 20 01 00 00 48 8b 80 80 00 00 00 48 89 0c 
+Code: 67 ff ff ff e9 80 fe ff ff 48 89 df e8 ba c4 fe ff 31 c9 e9 60 ff ff =
+ff 44 89 ee 4c 89 e7 e8 c8 6d ff ff 48 89 c1 49 8b 44 24 18 <48> 63 51 5c 4=
+8 8b 80 20 01 00 00 48 8b 80 80 00 00 00 48 89 0c=20
 RIP: blk_mq_sched_get_request+0x310/0x350 RSP: ffffc9000569bac8
 CR2: 000000000000005c
 
 (gdb) list *(blk_mq_sched_get_request+0x310)
-0xffffffff8132dcf0 is in blk_mq_sched_get_request (block/blk-mq-sched.c:136).
-131                                     rq->rq_flags |= RQF_QUEUED;
-132                     } else
-133                             rq = __blk_mq_alloc_request(data, op);
-134             } else {
-135                     rq = __blk_mq_alloc_request(data, op);
-136                     data->hctx->tags->rqs[rq->tag] = rq;
-137             }
+0xffffffff8132dcf0 is in blk_mq_sched_get_request (block/blk-mq-sched.c:136=
+).
+131 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0rq->rq_flags |=3D RQF_QUEUED;
+132 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0} else
+133 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
+=A0=A0=A0=A0=A0rq =3D __blk_mq_alloc_request(data, op);
+134 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0} else {
+135 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0rq =3D __bl=
+k_mq_alloc_request(data, op);
+136 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0data->hctx-=
+>tags->rqs[rq->tag] =3D rq;
+137 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0}
 138
-139             if (rq) {
-140                     if (!op_is_flush(op)) {
+139 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (rq) {
+140 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!op_is_=
+flush(op)) {
 
 (gdb) disas blk_mq_sched_get_request
 [ ... ]
-   0xffffffff8132dce3 <+771>:   callq  0xffffffff81324ab0 <__blk_mq_alloc_request>
-   0xffffffff8132dce8 <+776>:   mov    %rax,%rcx
-   0xffffffff8132dceb <+779>:   mov    0x18(%r12),%rax
-   0xffffffff8132dcf0 <+784>:   movslq 0x5c(%rcx),%rdx
+ =A0=A00xffffffff8132dce3 <+771>: =A0=A0callq =A00xffffffff81324ab0 <__blk_=
+mq_alloc_request>
+ =A0=A00xffffffff8132dce8 <+776>: =A0=A0mov =A0=A0=A0%rax,%rcx
+ =A0=A00xffffffff8132dceb <+779>: =A0=A0mov =A0=A0=A00x18(%r12),%rax
+ =A0=A00xffffffff8132dcf0 <+784>: =A0=A0movslq 0x5c(%rcx),%rdx
 [ ... ]
 (gdb) print &((struct request *)0)->tag
-$1 = (int *) 0x5c <irq_stack_union+92>
+$1 =3D (int *) 0x5c <irq_stack_union+92>
 
-I think this means that rq == NULL and that a test for rq is missing after the
+I think this means that rq =3D=3D NULL and that a test for rq is missing af=
+ter the
 __blk_mq_alloc_request() call?
 
-Bart.
+Bart.=
diff --git a/a/content_digest b/N1/content_digest
index 3941df5..f7418f0 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -10,15 +10,15 @@
  "ref\01485464486.2540.12.camel@sandisk.com\0"
  "ref\06995c991-65a4-8dca-c36e-fb2eff277ca9@fb.com\0"
  "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0"
- "Subject\0Re: split scsi passthrough fields out of struct request V2\0"
+ "Subject\0Re: [dm-devel] split scsi passthrough fields out of struct request V2\0"
  "Date\0Thu, 26 Jan 2017 21:47:36 +0000\0"
  "To\0hch@lst.de <hch@lst.de>"
  " axboe@fb.com <axboe@fb.com>\0"
- "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>"
-  linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>
-  snitzer@redhat.com <snitzer@redhat.com>
+ "Cc\0linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>"
   linux-raid@vger.kernel.org <linux-raid@vger.kernel.org>
   dm-devel@redhat.com <dm-devel@redhat.com>
+  linux-block@vger.kernel.org <linux-block@vger.kernel.org>
+  snitzer@redhat.com <snitzer@redhat.com>
  " j-nomura@ce.jp.nec.com <j-nomura@ce.jp.nec.com>\0"
  "\00:1\0"
  "b\0"
@@ -27,16 +27,16 @@
  "> > On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote:\n"
  "> > > Your call path has blk_get_request() in it, I don't have\n"
  "> > > that in my tree. Is it passing in the right mask?\n"
- "> > \n"
+ "> >=20\n"
  "> > Hello Jens,\n"
- "> > \n"
+ "> >=20\n"
  "> > There is only one blk_get_request() call in drivers/md/dm-mpath.c\n"
  "> > and it looks as follows:\n"
- "> > \n"
- "> >  \tclone = blk_get_request(bdev_get_queue(bdev),\n"
+ "> >=20\n"
+ "> >  \tclone =3D blk_get_request(bdev_get_queue(bdev),\n"
  "> > \t\t\trq->cmd_flags | REQ_NOMERGE,\n"
  "> > \t\t\tGFP_ATOMIC);\n"
- "> \n"
+ ">=20\n"
  "> Yeah, I found it in the dm patch. Looks fine to me, since\n"
  "> blk_mq_alloc_request() checks for __GFP_DIRECT_RECLAIM. Weird, it all\n"
  "> looks fine to me. Are you sure you tested with the patch? Either that,\n"
@@ -52,12 +52,28 @@
  "\n"
  "BUG: unable to handle kernel NULL pointer dereference at 000000000000005c\n"
  "IP: blk_mq_sched_get_request+0x310/0x350\n"
- "PGD 34bd9c067 \n"
- "PUD 346b37067 \n"
- "PMD 0 \n"
+ "PGD 34bd9c067=20\n"
+ "PUD 346b37067=20\n"
+ "PMD 0=20\n"
  "\n"
  "Oops: 0000 [#1] SMP\n"
- "Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_user uio target_core_pscsi target_core_file ib_srpt target_core_iblock target_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_intel pcbc aesni_intel aes_x86_64 tg3 iTCO_wdt crypto_simd dcdbas iTCO_vendor_support ptp glue_helper ipmi_si cryptd ipmi_devintf pps_core fjes devlink ipmi_msghandler pcspkr libphy tpm_tis tpm_tis_core tpm button mei_me lpc_ich wmi mei mfd_core shpchp hid_generic usbhid mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod drm cdrom ehci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua autofs4\n"
+ "Modules linked in: dm_service_time ib_srp scsi_transport_srp target_core_us=\n"
+ "er uio target_core_pscsi target_core_file ib_srpt target_core_iblock target=\n"
+ "_core_mod brd netconsole xt_CHECKSUM iptable_mangle ipt_MASQUERADE nf_nat_m=\n"
+ "asquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat libcrc32c nf_conntrack_ipv4 n=\n"
+ "f_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp=\n"
+ " tun bridge stp llc ebtable_filter ebtables ip6table_filter ip6_tables ipta=\n"
+ "ble_filter ip_tables x_tables af_packet ib_ipoib rdma_ucm ib_ucm ib_uverbs =\n"
+ "ib_umad rdma_cm configfs ib_cm iw_cm msr mlx4_ib ib_core sb_edac edac_core =\n"
+ "x86_pkg_temp_thermal intel_powerclamp coretemp ipmi_ssif kvm_intel kvm irqb=\n"
+ "ypass crct10dif_pclmul crc32_pclmul mlx4_core crc32c_intel ghash_clmulni_in=\n"
+ "tel pcbc aesni_intel aes_x86_64 tg3 iTCO_wdt crypto_simd dcdbas iTCO_vendor=\n"
+ "_support ptp glue_helper ipmi_si cryptd ipmi_devintf pps_core fjes devlink =\n"
+ "ipmi_msghandler pcspkr libphy tpm_tis tpm_tis_core tpm button mei_me lpc_ic=\n"
+ "h wmi mei mfd_core shpchp hid_generic usbhid mgag200 i2c_algo_bit drm_kms_h=\n"
+ "elper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm sr_mod drm cdrom eh=\n"
+ "ci_pci ehci_hcd usbcore usb_common sg dm_multipath dm_mod scsi_dh_rdac scsi=\n"
+ "_dh_emc scsi_dh_alua autofs4\n"
  "CPU: 0 PID: 9231 Comm: fio Not tainted 4.10.0-rc4-dbg+ #1\n"
  "Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014\n"
  "task: ffff88034c8c3140 task.stack: ffffc90005698000\n"
@@ -68,7 +84,8 @@
  "RBP: ffffc9000569bb00 R08: 0000000000000001 R09: 0000000000000000\n"
  "R10: 0000000000000001 R11: 0000000000000000 R12: ffffc9000569bb18\n"
  "R13: 000000000000c801 R14: 0000000000000000 R15: 0000000000000000\n"
- "FS:  00007f65ca054700(0000) GS:ffff88046f200000(0000) knlGS:0000000000000000\n"
+ "FS:  00007f65ca054700(0000) GS:ffff88046f200000(0000) knlGS:000000000000000=\n"
+ "0\n"
  "CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n"
  "CR2: 000000000000005c CR3: 000000034b0ed000 CR4: 00000000001406f0\n"
  "Call Trace:\n"
@@ -94,36 +111,46 @@
  "RBP: 0000000000000815 R08: 0000000000000001 R09: 00007f65a404e3e0\n"
  "R10: 00007f65a4040000 R11: 0000000000000202 R12: 00000000000006d0\n"
  "R13: 00007f65a404e930 R14: 0000000000001000 R15: 0000000000000830\n"
- "Code: 67 ff ff ff e9 80 fe ff ff 48 89 df e8 ba c4 fe ff 31 c9 e9 60 ff ff ff 44 89 ee 4c 89 e7 e8 c8 6d ff ff 48 89 c1 49 8b 44 24 18 <48> 63 51 5c 48 8b 80 20 01 00 00 48 8b 80 80 00 00 00 48 89 0c \n"
+ "Code: 67 ff ff ff e9 80 fe ff ff 48 89 df e8 ba c4 fe ff 31 c9 e9 60 ff ff =\n"
+ "ff 44 89 ee 4c 89 e7 e8 c8 6d ff ff 48 89 c1 49 8b 44 24 18 <48> 63 51 5c 4=\n"
+ "8 8b 80 20 01 00 00 48 8b 80 80 00 00 00 48 89 0c=20\n"
  "RIP: blk_mq_sched_get_request+0x310/0x350 RSP: ffffc9000569bac8\n"
  "CR2: 000000000000005c\n"
  "\n"
  "(gdb) list *(blk_mq_sched_get_request+0x310)\n"
- "0xffffffff8132dcf0 is in blk_mq_sched_get_request (block/blk-mq-sched.c:136).\n"
- "131 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240rq->rq_flags |= RQF_QUEUED;\n"
- "132 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240} else\n"
- "133 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240rq = __blk_mq_alloc_request(data, op);\n"
- "134 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240} else {\n"
- "135 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240rq = __blk_mq_alloc_request(data, op);\n"
- "136 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240data->hctx->tags->rqs[rq->tag] = rq;\n"
- "137 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n"
+ "0xffffffff8132dcf0 is in blk_mq_sched_get_request (block/blk-mq-sched.c:136=\n"
+ ").\n"
+ "131 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=\n"
+ "=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0rq->rq_flags |=3D RQF_QUEUED;\n"
+ "132 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0} else\n"
+ "133 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=\n"
+ "=A0=A0=A0=A0=A0rq =3D __blk_mq_alloc_request(data, op);\n"
+ "134 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0} else {\n"
+ "135 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0rq =3D __bl=\n"
+ "k_mq_alloc_request(data, op);\n"
+ "136 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0data->hctx-=\n"
+ ">tags->rqs[rq->tag] =3D rq;\n"
+ "137 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0}\n"
  "138\n"
- "139 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (rq) {\n"
- "140 \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!op_is_flush(op)) {\n"
+ "139 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (rq) {\n"
+ "140 =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!op_is_=\n"
+ "flush(op)) {\n"
  "\n"
  "(gdb) disas blk_mq_sched_get_request\n"
  "[ ... ]\n"
- " \302\240\302\2400xffffffff8132dce3 <+771>: \302\240\302\240callq \302\2400xffffffff81324ab0 <__blk_mq_alloc_request>\n"
- " \302\240\302\2400xffffffff8132dce8 <+776>: \302\240\302\240mov \302\240\302\240\302\240%rax,%rcx\n"
- " \302\240\302\2400xffffffff8132dceb <+779>: \302\240\302\240mov \302\240\302\240\302\2400x18(%r12),%rax\n"
- " \302\240\302\2400xffffffff8132dcf0 <+784>: \302\240\302\240movslq 0x5c(%rcx),%rdx\n"
+ " =A0=A00xffffffff8132dce3 <+771>: =A0=A0callq =A00xffffffff81324ab0 <__blk_=\n"
+ "mq_alloc_request>\n"
+ " =A0=A00xffffffff8132dce8 <+776>: =A0=A0mov =A0=A0=A0%rax,%rcx\n"
+ " =A0=A00xffffffff8132dceb <+779>: =A0=A0mov =A0=A0=A00x18(%r12),%rax\n"
+ " =A0=A00xffffffff8132dcf0 <+784>: =A0=A0movslq 0x5c(%rcx),%rdx\n"
  "[ ... ]\n"
  "(gdb) print &((struct request *)0)->tag\n"
- "$1 = (int *) 0x5c <irq_stack_union+92>\n"
+ "$1 =3D (int *) 0x5c <irq_stack_union+92>\n"
  "\n"
- "I think this means that rq == NULL and that a test for rq is missing after the\n"
+ "I think this means that rq =3D=3D NULL and that a test for rq is missing af=\n"
+ "ter the\n"
  "__blk_mq_alloc_request() call?\n"
  "\n"
- Bart.
+ Bart.=
 
-f8e4787513a13a5dc79261edf12f9c54d4b4c6778a633438050f31578a9e2d30
+219438a33130d93d43705e2d16392e7730747a9e103c4c57d08da8517b3dbcb7

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.