From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 03/18] block: fix elevator init check Date: Thu, 26 Jan 2017 23:21:49 +0000 Message-ID: <1485472889.2540.22.camel@sandisk.com> References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485365126-23210-4-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1485365126-23210-4-git-send-email-hch@lst.de> Content-Language: en-US Content-ID: Sender: linux-scsi-owner@vger.kernel.org To: "hch@lst.de" , "axboe@fb.com" Cc: "linux-scsi@vger.kernel.org" , "linux-raid@vger.kernel.org" , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" , "j-nomura@ce.jp.nec.com" List-Id: dm-devel.ids On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > We can't initalize the elevator fields for flushes as flush share space > in struct request with the elevator data. But currently we can't > commnicate that a request is a flush through blk_get_request as we > can only pass READ or WRITE, and the low-level code looks at the > possible NULL bio to check for a flush. >=20 > Fix this by allowing to pass any block op and flags, and by checking for > the flush flags in __get_request. Reviewed-by: Bart Van Assche = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "hch@lst.de" , "axboe@fb.com" CC: "linux-scsi@vger.kernel.org" , "linux-raid@vger.kernel.org" , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" , "j-nomura@ce.jp.nec.com" Subject: Re: [PATCH 03/18] block: fix elevator init check Date: Thu, 26 Jan 2017 23:21:49 +0000 Message-ID: <1485472889.2540.22.camel@sandisk.com> References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485365126-23210-4-git-send-email-hch@lst.de> In-Reply-To: <1485365126-23210-4-git-send-email-hch@lst.de> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org List-ID: On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > We can't initalize the elevator fields for flushes as flush share space > in struct request with the elevator data. But currently we can't > commnicate that a request is a flush through blk_get_request as we > can only pass READ or WRITE, and the low-level code looks at the > possible NULL bio to check for a flush. >=20 > Fix this by allowing to pass any block op and flags, and by checking for > the flush flags in __get_request. Reviewed-by: Bart Van Assche =