diff for duplicates of <1485512586.2693.35.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 9351112..f533ec4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ -Hi?Giuseppe, +Hi Giuseppe, -On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote: +On Wed, 2017-01-25 at 21:39 +0300, Alexey Brodkin wrote: > Hi Giuseppe, > -> On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote: +> On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote: > > > > Hello Alexey > > @@ -15,7 +15,7 @@ On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote: > Yep looks like that. Hm, so I took a look at what am I reading from -"Register 22 (HW Feature Register)" in?dwmac1000_get_hw_feature() +"Register 22 (HW Feature Register)" in dwmac1000_get_hw_feature() and was really surprised to see the register value = 0x100509bf. See bit 6 "PCSSEL" is zeroed which stands for @@ -56,20 +56,20 @@ below should be discarded. > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv) -> ????????int interface = priv->plat->interface; -> ? -> ????????if (priv->dma_cap.pcs) { -> -???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) { -> -???????????????????????netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); -> -???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII; -> -???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) { -> +???????????????if (interface == PHY_INTERFACE_MODE_SGMII) { -> ????????????????????????netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); -> ????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII; -> ????????????????} +> int interface = priv->plat->interface; +> +> if (priv->dma_cap.pcs) { +> - if ((interface == PHY_INTERFACE_MODE_RGMII) || +> - (interface == PHY_INTERFACE_MODE_RGMII_ID) || +> - (interface == PHY_INTERFACE_MODE_RGMII_RXID) || +> - (interface == PHY_INTERFACE_MODE_RGMII_TXID)) { +> - netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); +> - priv->hw->pcs = STMMAC_PCS_RGMII; +> - } else if (interface == PHY_INTERFACE_MODE_SGMII) { +> + if (interface == PHY_INTERFACE_MODE_SGMII) { +> netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); +> priv->hw->pcs = STMMAC_PCS_SGMII; +> } > --------------------------->8-------------------------- > > > diff --git a/a/content_digest b/N1/content_digest index 9608726..db9087a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,27 @@ "ref\01478189833.4072.65.camel@synopsys.com\0" "ref\0a1f114cc-6120-154c-a3f7-3e0389d38e36@st.com\0" "ref\01485369563.7117.81.camel@synopsys.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0stmmac: GMAC_RGSMIIIS reports bogus values\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: stmmac: GMAC_RGSMIIIS reports bogus values\0" "Date\0Fri, 27 Jan 2017 10:23:06 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0peppe.cavallaro@st.com <peppe.cavallaro@st.com>\0" + "Cc\0manabian@gmail.com <manabian@gmail.com>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + fabrice.gasnier@st.com <fabrice.gasnier@st.com> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + alexandre.torgue@gmail.com <alexandre.torgue@gmail.com> + preid@electromag.com.au <preid@electromag.com.au> + netdev@vger.kernel.org <netdev@vger.kernel.org> + Vineet Gupta <Vineet.Gupta1@synopsys.com> + " davem@davemloft.net <davem@davemloft.net>\0" "\00:1\0" "b\0" - "Hi?Giuseppe,\n" + "Hi\302\240Giuseppe,\n" "\n" - "On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote:\n" + "On Wed, 2017-01-25 at 21:39 +0300, Alexey Brodkin wrote:\n" "> Hi Giuseppe,\n" "> \n" - "> On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote:\n" + "> On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote:\n" "> > \n" "> > Hello Alexey\n" "> > \n" @@ -24,7 +33,7 @@ "> Yep looks like that.\n" "\n" "Hm, so I took a look at what am I reading from\n" - "\"Register 22 (HW Feature Register)\" in?dwmac1000_get_hw_feature()\n" + "\"Register 22 (HW Feature Register)\" in\302\240dwmac1000_get_hw_feature()\n" "and was really surprised to see the register value = 0x100509bf.\n" "\n" "See bit 6 \"PCSSEL\" is zeroed which stands for\n" @@ -65,20 +74,20 @@ "> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "> @@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)\n" - "> ????????int interface = priv->plat->interface;\n" - "> ?\n" - "> ????????if (priv->dma_cap.pcs) {\n" - "> -???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" - "> -???????????????????????netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" - "> -???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII;\n" - "> -???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "> +???????????????if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "> ????????????????????????netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" - "> ????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII;\n" - "> ????????????????}\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240int interface = priv->plat->interface;\n" + "> \302\240\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (priv->dma_cap.pcs) {\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_RGMII;\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_SGMII;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "> --------------------------->8--------------------------\n" "> \n" "> > \n" @@ -98,4 +107,4 @@ "\n" -Alexey -4d84295093b935949c74fc17976498b606048ae6bdf47def243c04734fd74bda +89c1458252757d137dd3d8efb841ed2fbe6a6f2a221be118ab84e6a0fc97e979
diff --git a/a/1.txt b/N2/1.txt index 9351112..42a26c6 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,9 +1,9 @@ -Hi?Giuseppe, +Hi Giuseppe, -On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote: +On Wed, 2017-01-25 at 21:39 +0300, Alexey Brodkin wrote: > Hi Giuseppe, > -> On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote: +> On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote: > > > > Hello Alexey > > @@ -15,7 +15,7 @@ On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote: > Yep looks like that. Hm, so I took a look at what am I reading from -"Register 22 (HW Feature Register)" in?dwmac1000_get_hw_feature() +"Register 22 (HW Feature Register)" in dwmac1000_get_hw_feature() and was really surprised to see the register value = 0x100509bf. See bit 6 "PCSSEL" is zeroed which stands for @@ -56,20 +56,20 @@ below should be discarded. > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv) -> ????????int interface = priv->plat->interface; -> ? -> ????????if (priv->dma_cap.pcs) { -> -???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) || -> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) { -> -???????????????????????netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); -> -???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII; -> -???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) { -> +???????????????if (interface == PHY_INTERFACE_MODE_SGMII) { -> ????????????????????????netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); -> ????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII; -> ????????????????} +> int interface = priv->plat->interface; +> +> if (priv->dma_cap.pcs) { +> - if ((interface == PHY_INTERFACE_MODE_RGMII) || +> - (interface == PHY_INTERFACE_MODE_RGMII_ID) || +> - (interface == PHY_INTERFACE_MODE_RGMII_RXID) || +> - (interface == PHY_INTERFACE_MODE_RGMII_TXID)) { +> - netdev_dbg(priv->dev, "PCS RGMII support enabled\n"); +> - priv->hw->pcs = STMMAC_PCS_RGMII; +> - } else if (interface == PHY_INTERFACE_MODE_SGMII) { +> + if (interface == PHY_INTERFACE_MODE_SGMII) { +> netdev_dbg(priv->dev, "PCS SGMII support enabled\n"); +> priv->hw->pcs = STMMAC_PCS_SGMII; +> } > --------------------------->8-------------------------- > > > @@ -88,3 +88,8 @@ That's why my initial proposal was to ignore whatever we read from this register if we have MDIO bus instantiated already. -Alexey + +_______________________________________________ +linux-snps-arc mailing list +linux-snps-arc@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-snps-arc diff --git a/a/content_digest b/N2/content_digest index 9608726..7617be2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,18 +1,27 @@ "ref\01478189833.4072.65.camel@synopsys.com\0" "ref\0a1f114cc-6120-154c-a3f7-3e0389d38e36@st.com\0" "ref\01485369563.7117.81.camel@synopsys.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0stmmac: GMAC_RGSMIIIS reports bogus values\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: stmmac: GMAC_RGSMIIIS reports bogus values\0" "Date\0Fri, 27 Jan 2017 10:23:06 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0peppe.cavallaro@st.com <peppe.cavallaro@st.com>\0" + "Cc\0fabrice.gasnier@st.com <fabrice.gasnier@st.com>" + netdev@vger.kernel.org <netdev@vger.kernel.org> + manabian@gmail.com <manabian@gmail.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + preid@electromag.com.au <preid@electromag.com.au> + davem@davemloft.net <davem@davemloft.net> + alexandre.torgue@gmail.com <alexandre.torgue@gmail.com> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + " Vineet Gupta <Vineet.Gupta1@synopsys.com>\0" "\00:1\0" "b\0" - "Hi?Giuseppe,\n" + "Hi\302\240Giuseppe,\n" "\n" - "On Wed, 2017-01-25@21:39 +0300, Alexey Brodkin wrote:\n" + "On Wed, 2017-01-25 at 21:39 +0300, Alexey Brodkin wrote:\n" "> Hi Giuseppe,\n" "> \n" - "> On Mon, 2016-11-14@09:14 +0100, Giuseppe CAVALLARO wrote:\n" + "> On Mon, 2016-11-14 at 09:14 +0100, Giuseppe CAVALLARO wrote:\n" "> > \n" "> > Hello Alexey\n" "> > \n" @@ -24,7 +33,7 @@ "> Yep looks like that.\n" "\n" "Hm, so I took a look at what am I reading from\n" - "\"Register 22 (HW Feature Register)\" in?dwmac1000_get_hw_feature()\n" + "\"Register 22 (HW Feature Register)\" in\302\240dwmac1000_get_hw_feature()\n" "and was really surprised to see the register value = 0x100509bf.\n" "\n" "See bit 6 \"PCSSEL\" is zeroed which stands for\n" @@ -65,20 +74,20 @@ "> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n" "> @@ -803,13 +803,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)\n" - "> ????????int interface = priv->plat->interface;\n" - "> ?\n" - "> ????????if (priv->dma_cap.pcs) {\n" - "> -???????????????if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" - "> -???????????????????(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" - "> -???????????????????????netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" - "> -???????????????????????priv->hw->pcs = STMMAC_PCS_RGMII;\n" - "> -???????????????} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "> +???????????????if (interface == PHY_INTERFACE_MODE_SGMII) {\n" - "> ????????????????????????netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" - "> ????????????????????????priv->hw->pcs = STMMAC_PCS_SGMII;\n" - "> ????????????????}\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240int interface = priv->plat->interface;\n" + "> \302\240\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (priv->dma_cap.pcs) {\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if ((interface == PHY_INTERFACE_MODE_RGMII) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_ID) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_RXID) ||\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(interface == PHY_INTERFACE_MODE_RGMII_TXID)) {\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS RGMII support enabled\\n\");\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_RGMII;\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240} else if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (interface == PHY_INTERFACE_MODE_SGMII) {\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240netdev_dbg(priv->dev, \"PCS SGMII support enabled\\n\");\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240priv->hw->pcs = STMMAC_PCS_SGMII;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "> --------------------------->8--------------------------\n" "> \n" "> > \n" @@ -96,6 +105,11 @@ "That's why my initial proposal was to ignore whatever we read from this register\n" "if we have MDIO bus instantiated already.\n" "\n" - -Alexey + "-Alexey\n" + "\n" + "_______________________________________________\n" + "linux-snps-arc mailing list\n" + "linux-snps-arc@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-snps-arc -4d84295093b935949c74fc17976498b606048ae6bdf47def243c04734fd74bda +2370f4863648ad85409549c3653aef50dd402fb54ff9658a730f9b3dc927822c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.