From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754952AbdA0Nhn (ORCPT ); Fri, 27 Jan 2017 08:37:43 -0500 Received: from mga11.intel.com ([192.55.52.93]:23184 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754945AbdA0Nh1 (ORCPT ); Fri, 27 Jan 2017 08:37:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,295,1477983600"; d="scan'208";a="1118625373" Message-ID: <1485523197.2133.352.camel@linux.intel.com> Subject: Re: [char-misc-next V3] mei: simplify error handling via devres function. From: Andy Shevchenko To: Greg Kroah-Hartman , Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Date: Fri, 27 Jan 2017 15:19:57 +0200 In-Reply-To: <20170127081515.GA29246@kroah.com> References: <1485443786-27337-1-git-send-email-tomas.winkler@intel.com> <20170127081515.GA29246@kroah.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-27 at 09:15 +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote: > > Use devm_ and pcim_ functions to make error handling > > simpler and code smaller and tidier. > > > > Based on original patch by > > mei: me: use managed functions pcim_* and devm_* > > https://lkml.org/lkml/2016/2/1/339 > > > > Signed-off-by: Tomas Winkler > > Signed-off-by: Alexander Usyskin > > Signed-off-by: Andy Shevchenko > > --- > > V2: Thanks Andy for review, integratd changes: > >     1. Rename devm_mei_me_init back to mei_me_dev_init > >        they don't really belong to devm_ namespace. > >     2. Revert pcim irq reservation change. > >     3. Drop setting driver data to NULL on exit. > >     4. Use directly mmio pointer received from pcim_iomap_table > > V3: Remove pci_disable_msi, it is also handled by the system. > > Andy, any objection to this version? Nope, this looks exactly how I would put it! Thanks! -- Andy Shevchenko Intel Finland Oy