From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932627AbdA0N5Y (ORCPT ); Fri, 27 Jan 2017 08:57:24 -0500 Received: from smtprelay0012.hostedemail.com ([216.40.44.12]:40251 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932415AbdA0N5C (ORCPT ); Fri, 27 Jan 2017 08:57:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4362:4605:5007:6119:6120:7514:7901:7903:10004:10400:10848:11026:11232:11233:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21067:21080:21220:21434:21451:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: dock50_6d86a2e6fdf4a X-Filterd-Recvd-Size: 3070 Message-ID: <1485524751.12563.124.camel@perches.com> Subject: Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute From: Joe Perches To: "Gideon D'souza" Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , Greg Ungerer , Geert Uytterhoeven , linux-m68k Date: Fri, 27 Jan 2017 05:45:51 -0800 In-Reply-To: References: <1485260068-2495-1-git-send-email-gidisrael@gmail.com> <1485309036.12563.46.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote: > Ok, I noticed this went into Andrew's tree and is now in linux-next, > should I resend it? Please don't top post and perhaps Andrew can fix it up instead. Andrew, you need to change: #define __mode __attribute__((mode(x))) to #define __mode(x) __attribute__((mode(x))) thanks. > On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza wrote: > > > #define __mode(x) __attribute__((mode(x))) > > > > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this. > > > > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches wrote: > > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: > > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've > > > > taken up, to replace gcc specific attributes with macros. > > > > > > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: > > > > crypto: Replaced gcc specific attributes with macros from compiler.h > > > > > > > > The last commit of this task that went through you: 52f5684c8e1ec > > > > kernel: use macros from compiler.h instead of __attribute__((...)) > > > > > > > > The next patch is for cleaning up the m68k subsystem and it requires > > > > a new macro to wrap __attribute__ ((mode (...))) > > > > > > [] > > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > > > > > > [] > > > > @@ -121,6 +121,7 @@ > > > > #define __attribute_const__ __attribute__((__const__)) > > > > #define __maybe_unused __attribute__((unused)) > > > > #define __always_unused __attribute__((unused)) > > > > +#define __mode __attribute__((mode(x))) > > > > > > Huh? > > > > > > Perhaps you meant > > > > > > #define __mode(x) __attribute__((mode(x))) > > > > > > ? > > >