diff for duplicates of <1485538224.4267.9.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 2d96d06..0c35e51 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,30 +3,35 @@ On Fri, 2017-01-27 at 10:26 -0700, Jens Axboe wrote: > > On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: > > > On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote: > > > > +static void *alloc_request_size(gfp_t gfp_mask, void *data) -> > > > +> > > >=20 > > > > I like alloc_request_simple() but alloc_request_size() seems a bit -> > > > contrived. _reserve? _extra? _special? Don't have any good suggestions, +> > > > contrived. _reserve? _extra? _special? Don't have any good suggesti= +ons, > > > > I'm afraid. -> > > -> > > Not that I'm a fan of _size, but I like the other suggestions even less. -> > +> > >=20 +> > > Not that I'm a fan of _size, but I like the other suggestions even le= +ss. +> >=20 > > Hello Christoph and Martin, -> > -> > How about using the function names alloc_full_request() / free_full_request() +> >=20 +> > How about using the function names alloc_full_request() / free_full_req= +uest() > > together with a comment that mentions that cmd_size is set by the LLD? -> +>=20 > Since we use pdu in other places, how about alloc_request_pdu() or > alloc_request_with_pdu()? -> +>=20 > And since it's all queued up, any bike shedding changes will have to be > incremental. Hello Jens, -Other Linux subsystems use the term "private data" instead of PDU. How about +Other Linux subsystems use the term "private data" instead of PDU. How abou= +t modifying the block layer such that it uses the same terminology? I'm -referring to function names like blk_mq_rq_from_pdu() and blk_mq_rq_to_pdu() +referring to function names like blk_mq_rq_from_pdu() and blk_mq_rq_to_pdu(= +) Thanks, -Bart. +Bart.= diff --git a/a/content_digest b/N1/content_digest index 677625d..ebd7005 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -10,11 +10,11 @@ "To\0hch@lst.de <hch@lst.de>" axboe@fb.com <axboe@fb.com> " martin.petersen@oracle.com <martin.petersen@oracle.com>\0" - "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>" - linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org> - snitzer@redhat.com <snitzer@redhat.com> + "Cc\0linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>" linux-raid@vger.kernel.org <linux-raid@vger.kernel.org> dm-devel@redhat.com <dm-devel@redhat.com> + linux-block@vger.kernel.org <linux-block@vger.kernel.org> + snitzer@redhat.com <snitzer@redhat.com> " j-nomura@ce.jp.nec.com <j-nomura@ce.jp.nec.com>\0" "\00:1\0" "b\0" @@ -23,32 +23,37 @@ "> > On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote:\n" "> > > On Wed, Jan 25, 2017 at 10:15:55PM -0500, Martin K. Petersen wrote:\n" "> > > > +static void *alloc_request_size(gfp_t gfp_mask, void *data)\n" - "> > > > \n" + "> > > >=20\n" "> > > > I like alloc_request_simple() but alloc_request_size() seems a bit\n" - "> > > > contrived. _reserve? _extra? _special? Don't have any good suggestions,\n" + "> > > > contrived. _reserve? _extra? _special? Don't have any good suggesti=\n" + "ons,\n" "> > > > I'm afraid.\n" - "> > > \n" - "> > > Not that I'm a fan of _size, but I like the other suggestions even less.\n" - "> > \n" + "> > >=20\n" + "> > > Not that I'm a fan of _size, but I like the other suggestions even le=\n" + "ss.\n" + "> >=20\n" "> > Hello Christoph and Martin,\n" - "> > \n" - "> > How about using the function names alloc_full_request() / free_full_request()\n" + "> >=20\n" + "> > How about using the function names alloc_full_request() / free_full_req=\n" + "uest()\n" "> > together with a comment that mentions that cmd_size is set by the LLD?\n" - "> \n" + ">=20\n" "> Since we use pdu in other places, how about alloc_request_pdu() or\n" "> alloc_request_with_pdu()?\n" - "> \n" + ">=20\n" "> And since it's all queued up, any bike shedding changes will have to be\n" "> incremental.\n" "\n" "Hello Jens,\n" "\n" - "Other Linux subsystems use the term \"private data\" instead of PDU. How about\n" + "Other Linux subsystems use the term \"private data\" instead of PDU. How abou=\n" + "t\n" "modifying the block layer such that it uses the same terminology? I'm\n" - "referring to function names like blk_mq_rq_from_pdu() and blk_mq_rq_to_pdu()\n" + "referring to function names like blk_mq_rq_from_pdu() and blk_mq_rq_to_pdu(=\n" + ")\n" "\n" "Thanks,\n" "\n" - Bart. + Bart.= -3b2d0fc2087616f7e5947d1db02e0bc231906eca3ae4b74f87f3c67e1fc03ba9 +8b8edc85797a695657b13fa779ecaf59e753b5dc01c3b66dd13004cf3fd055c5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.