diff for duplicates of <1485539862.4267.17.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index a0772a2..39dce37 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,25 +1,29 @@ On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: -> diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.h +> diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.= +h > index 8129239..b6e07b5 100644 > --- a/include/scsi/scsi_transport.h > +++ b/include/scsi/scsi_transport.h > @@ -119,4 +119,6 @@ scsi_transport_device_data(struct scsi_device *sdev) > + shost->transportt->device_private_offset; > } -> -> +void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q); +> =20 +> +void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)= +; > + > #endif /* SCSI_TRANSPORT_H */ Hello Christoph, -Since __scsi_init_queue() modifies data in the Scsi_Host structure, have you +Since __scsi_init_queue() modifies data in the Scsi_Host structure, have yo= +u considered to add the declaration for this function to <scsi/scsi_host.h>? -If you want to keep this declaration in <scsi/scsi_transport.h> please add a +If you want to keep this declaration in <scsi/scsi_transport.h> please add = +a direct include of that header file to drivers/scsi/scsi_lib.c such that the declaration remains visible to the compiler if someone would minimize the number of #include directives in SCSI header files. Thanks, -Bart. +Bart.= diff --git a/a/content_digest b/N1/content_digest index 60a0ff7..e709e70 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,38 +5,42 @@ "Date\0Fri, 27 Jan 2017 17:58:02 +0000\0" "To\0hch@lst.de <hch@lst.de>" " axboe@fb.com <axboe@fb.com>\0" - "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>" - linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org> - snitzer@redhat.com <snitzer@redhat.com> + "Cc\0linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>" linux-raid@vger.kernel.org <linux-raid@vger.kernel.org> dm-devel@redhat.com <dm-devel@redhat.com> + linux-block@vger.kernel.org <linux-block@vger.kernel.org> + snitzer@redhat.com <snitzer@redhat.com> " j-nomura@ce.jp.nec.com <j-nomura@ce.jp.nec.com>\0" "\00:1\0" "b\0" "On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:\n" - "> diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.h\n" + "> diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.=\n" + "h\n" "> index 8129239..b6e07b5 100644\n" "> --- a/include/scsi/scsi_transport.h\n" "> +++ b/include/scsi/scsi_transport.h\n" "> @@ -119,4 +119,6 @@ scsi_transport_device_data(struct scsi_device *sdev)\n" "> \t\t+ shost->transportt->device_private_offset;\n" "> }\n" - "> \n" - "> +void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q);\n" + "> =20\n" + "> +void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)=\n" + ";\n" "> +\n" "> #endif /* SCSI_TRANSPORT_H */\n" "\n" "Hello Christoph,\n" "\n" - "Since __scsi_init_queue() modifies data in the Scsi_Host structure, have you\n" + "Since __scsi_init_queue() modifies data in the Scsi_Host structure, have yo=\n" + "u\n" "considered to add the declaration for this function to <scsi/scsi_host.h>?\n" - "If you want to keep this declaration in <scsi/scsi_transport.h> please add a\n" + "If you want to keep this declaration in <scsi/scsi_transport.h> please add =\n" + "a\n" "direct include of that header file to drivers/scsi/scsi_lib.c such that the\n" "declaration remains visible to the compiler if someone would minimize the\n" "number of #include directives in SCSI header files.\n" "\n" "Thanks,\n" "\n" - Bart. + Bart.= -1390bc04be4f6a03244d54366291a0b8ddb7e2fddb0a144101a3a6ccd46588ee +9692715af82d057dd979b8f0834e80402efc3a3bbf4ca75c418f006b7c78ce55
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.