diff for duplicates of <1485542367.4267.19.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index b382bd9..af6b952 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,45 @@ On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: -> -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t gfp_mask, -> - int numa_node) +> -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t gf= +p_mask, +> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0int numa_node) > +static unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, -> + gfp_t gfp_mask, int numa_node) -> { -> return kmem_cache_alloc_node(scsi_select_sense_cache(shost), gfp_mask, -> numa_node); -> @@ -697,14 +696,13 @@ static bool scsi_end_request(struct request *req, int error, -> -> if (bidi_bytes) -> scsi_release_bidi_buffers(cmd); -> + scsi_release_buffers(cmd); -> + scsi_put_command(cmd); -> -> spin_lock_irqsave(q->queue_lock, flags); -> blk_finish_request(req, error); -> spin_unlock_irqrestore(q->queue_lock, flags); -> -> - scsi_release_buffers(cmd); +> +=A0=A0=A0=A0=A0=A0=A0gfp_t gfp_mask, int numa_node) +> =A0{ +> =A0=A0=A0=A0=A0=A0=A0=A0return kmem_cache_alloc_node(scsi_select_sense_ca= +che(shost), gfp_mask, +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0n= +uma_node); +> @@ -697,14 +696,13 @@ static bool scsi_end_request(struct request *req, i= +nt error, +> =A0 +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (bidi_bytes) +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0s= +csi_release_bidi_buffers(cmd); +> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_release_buffers(cmd); +> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_put_command(cmd); +> =A0 +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0spin_lock_irqsave(q->queu= +e_lock, flags); +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0blk_finish_request(req, e= +rror); +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0spin_unlock_irqrestore(q-= +>queue_lock, flags); +> =A0 +> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_release_buffers(cmd); > - -> - scsi_put_command(cmd); -> scsi_run_queue(q); -> } +> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_put_command(cmd); +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_run_queue(q); +> =A0=A0=A0=A0=A0=A0=A0=A0} Hello Christoph, -Why have the scsi_release_buffers() and scsi_put_command(cmd) calls been +Why=A0have the=A0scsi_release_buffers() and scsi_put_command(cmd) calls bee= +n moved up? I haven't found an explanation for this change in the patch description. -Please also consider to remove the cmd->request->special = NULL assignments +Please also consider to remove the cmd->request->special =3D NULL assignmen= +ts via this patch. Since this patch makes the lifetime of struct scsi_cmnd and struct request identical these assignments are no longer needed. diff --git a/a/content_digest b/N1/content_digest index 31206ba..683f68d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,46 +5,56 @@ "Date\0Fri, 27 Jan 2017 18:39:46 +0000\0" "To\0hch@lst.de <hch@lst.de>" " axboe@fb.com <axboe@fb.com>\0" - "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>" - linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org> - snitzer@redhat.com <snitzer@redhat.com> + "Cc\0linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org>" linux-raid@vger.kernel.org <linux-raid@vger.kernel.org> dm-devel@redhat.com <dm-devel@redhat.com> + linux-block@vger.kernel.org <linux-block@vger.kernel.org> + snitzer@redhat.com <snitzer@redhat.com> " j-nomura@ce.jp.nec.com <j-nomura@ce.jp.nec.com>\0" "\00:1\0" "b\0" "On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:\n" - "> -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t gfp_mask,\n" - "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240int numa_node)\n" + "> -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t gf=\n" + "p_mask,\n" + "> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0int numa_node)\n" "> +static unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost,\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240gfp_t gfp_mask, int numa_node)\n" - "> \302\240{\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return kmem_cache_alloc_node(scsi_select_sense_cache(shost), gfp_mask,\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240numa_node);\n" - "> @@ -697,14 +696,13 @@ static bool scsi_end_request(struct request *req, int error,\n" - "> \302\240\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (bidi_bytes)\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_release_bidi_buffers(cmd);\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_release_buffers(cmd);\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_put_command(cmd);\n" - "> \302\240\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240spin_lock_irqsave(q->queue_lock, flags);\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240blk_finish_request(req, error);\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240spin_unlock_irqrestore(q->queue_lock, flags);\n" - "> \302\240\n" - "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_release_buffers(cmd);\n" + "> +=A0=A0=A0=A0=A0=A0=A0gfp_t gfp_mask, int numa_node)\n" + "> =A0{\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0return kmem_cache_alloc_node(scsi_select_sense_ca=\n" + "che(shost), gfp_mask,\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0n=\n" + "uma_node);\n" + "> @@ -697,14 +696,13 @@ static bool scsi_end_request(struct request *req, i=\n" + "nt error,\n" + "> =A0\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (bidi_bytes)\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0s=\n" + "csi_release_bidi_buffers(cmd);\n" + "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_release_buffers(cmd);\n" + "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_put_command(cmd);\n" + "> =A0\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0spin_lock_irqsave(q->queu=\n" + "e_lock, flags);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0blk_finish_request(req, e=\n" + "rror);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0spin_unlock_irqrestore(q-=\n" + ">queue_lock, flags);\n" + "> =A0\n" + "> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_release_buffers(cmd);\n" "> -\n" - "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_put_command(cmd);\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240scsi_run_queue(q);\n" - "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_put_command(cmd);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0scsi_run_queue(q);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0}\n" "\n" "Hello Christoph,\n" "\n" - "Why\302\240have the\302\240scsi_release_buffers() and scsi_put_command(cmd) calls been\n" + "Why=A0have the=A0scsi_release_buffers() and scsi_put_command(cmd) calls bee=\n" + "n\n" "moved up? I haven't found an explanation for this change in the patch\n" "description.\n" "\n" - "Please also consider to remove the cmd->request->special = NULL assignments\n" + "Please also consider to remove the cmd->request->special =3D NULL assignmen=\n" + "ts\n" "via this patch. Since this patch makes the lifetime of struct scsi_cmnd and\n" "struct request identical these assignments are no longer needed.\n" "\n" @@ -59,4 +69,4 @@ "\n" Bart. -dadf2fb4fd50b65bfca0d9ad1898225e11b5568b10bf01471affae55fbd4ee46 +9a2b9b7ae14e9345340be9bad73ff6f2ac855675e39030bd60a7a1f021bdf6e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.