From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1485561102.9266.8.camel@buserror.net> From: Scott Wood To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Shawn Guo , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Y.B. Lu" , "Z.Q. Hou" , "Y.T. Tang" , devicetree@vger.kernel.org Date: Fri, 27 Jan 2017 17:51:42 -0600 In-Reply-To: <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> References: <1485332363-8434-1-git-send-email-oss@buserror.net> <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: [PATCH 1/3] dt-bindings: qoriq-clock: Add coreclk List-ID: On Fri, 2017-01-27 at 16:38 -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 02:19:21AM -0600, Scott Wood wrote: > > > > ls1012a has separate input root clocks for core PLLs versus the platform > > PLL, with the latter described as sysclk in the hw docs. > > > > Update the qoriq-clock binding to allow a second input clock, named > > "coreclk".  If present, this clock will be used for the core PLLs. > > > > Signed-off-by: Scott Wood > > Cc: devicetree@vger.kernel.org > > --- > >  Documentation/devicetree/bindings/clock/qoriq-clock.txt | 6 ++++++ > >  1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > index df9cb5a..97a9666 100644 > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > @@ -55,6 +55,11 @@ Optional properties: > >  - clocks: If clock-frequency is not specified, sysclk may be provided > >   as an input clock.  Either clock-frequency or clocks must be > >   provided. > > + A second input clock, called "coreclk", may be provided if > > + core PLLs are based on a different input clock from the > > + platform PLL. > > +- clock-names: Required if a coreclk is present.  Valid names are > > + "sysclk" and "coreclk". > 'clk' part is redundant. "sysclk" is a term used by the hardware documentation and I'd rather leave it intact.  "coreclk" isn't named (only described) by the hardware documentation but it is a special variant of sysclk and having similar naming helps make that clear. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: oss@buserror.net (Scott Wood) Date: Fri, 27 Jan 2017 17:51:42 -0600 Subject: [PATCH 1/3] dt-bindings: qoriq-clock: Add coreclk In-Reply-To: <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> References: <1485332363-8434-1-git-send-email-oss@buserror.net> <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> Message-ID: <1485561102.9266.8.camel@buserror.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-01-27 at 16:38 -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 02:19:21AM -0600, Scott Wood wrote: > > > > ls1012a has separate input root clocks for core PLLs versus the platform > > PLL, with the latter described as sysclk in the hw docs. > > > > Update the qoriq-clock binding to allow a second input clock, named > > "coreclk".??If present, this clock will be used for the core PLLs. > > > > Signed-off-by: Scott Wood > > Cc: devicetree at vger.kernel.org > > --- > > ?Documentation/devicetree/bindings/clock/qoriq-clock.txt | 6 ++++++ > > ?1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > index df9cb5a..97a9666 100644 > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > > @@ -55,6 +55,11 @@ Optional properties: > > ?- clocks: If clock-frequency is not specified, sysclk may be provided > > ? as an input clock.??Either clock-frequency or clocks must be > > ? provided. > > + A second input clock, called "coreclk", may be provided if > > + core PLLs are based on a different input clock from the > > + platform PLL. > > +- clock-names: Required if a coreclk is present.??Valid names are > > + "sysclk" and "coreclk". > 'clk' part is redundant. "sysclk" is a term used by the hardware documentation and I'd rather leave it intact. ?"coreclk" isn't named (only described) by the hardware documentation but it is a special variant of sysclk and having similar naming helps make that clear. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 1/3] dt-bindings: qoriq-clock: Add coreclk Date: Fri, 27 Jan 2017 17:51:42 -0600 Message-ID: <1485561102.9266.8.camel@buserror.net> References: <1485332363-8434-1-git-send-email-oss@buserror.net> <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170127223819.mzovhnnpths5t5w2@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: devicetree@vger.kernel.org, "Z.Q. Hou" , Michael Turquette , Stephen Boyd , "Y.T. Tang" , "Y.B. Lu" , Shawn Guo , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gRnJpLCAyMDE3LTAxLTI3IGF0IDE2OjM4IC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBXZWQsIEphbiAyNSwgMjAxNyBhdCAwMjoxOToyMUFNIC0wNjAwLCBTY290dCBXb29kIHdyb3Rl Ogo+ID4gCj4gPiBsczEwMTJhIGhhcyBzZXBhcmF0ZSBpbnB1dCByb290IGNsb2NrcyBmb3IgY29y ZSBQTExzIHZlcnN1cyB0aGUgcGxhdGZvcm0KPiA+IFBMTCwgd2l0aCB0aGUgbGF0dGVyIGRlc2Ny aWJlZCBhcyBzeXNjbGsgaW4gdGhlIGh3IGRvY3MuCj4gPiAKPiA+IFVwZGF0ZSB0aGUgcW9yaXEt Y2xvY2sgYmluZGluZyB0byBhbGxvdyBhIHNlY29uZCBpbnB1dCBjbG9jaywgbmFtZWQKPiA+ICJj b3JlY2xrIi7CoMKgSWYgcHJlc2VudCwgdGhpcyBjbG9jayB3aWxsIGJlIHVzZWQgZm9yIHRoZSBj b3JlIFBMTHMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFNjb3R0IFdvb2QgPG9zc0BidXNlcnJv ci5uZXQ+Cj4gPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmcKPiA+IC0tLQo+ID4gwqBE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2sudHh0IHwg NiArKysrKysKPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3Fvcmlx LWNsb2NrLnR4dAo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2sv cW9yaXEtY2xvY2sudHh0Cj4gPiBpbmRleCBkZjljYjVhLi45N2E5NjY2IDEwMDY0NAo+ID4gLS0t IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNsb2NrLnR4 dAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3Fvcmlx LWNsb2NrLnR4dAo+ID4gQEAgLTU1LDYgKzU1LDExIEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4g PiDCoC0gY2xvY2tzOiBJZiBjbG9jay1mcmVxdWVuY3kgaXMgbm90IHNwZWNpZmllZCwgc3lzY2xr IG1heSBiZSBwcm92aWRlZAo+ID4gwqAJYXMgYW4gaW5wdXQgY2xvY2suwqDCoEVpdGhlciBjbG9j ay1mcmVxdWVuY3kgb3IgY2xvY2tzIG11c3QgYmUKPiA+IMKgCXByb3ZpZGVkLgo+ID4gKwlBIHNl Y29uZCBpbnB1dCBjbG9jaywgY2FsbGVkICJjb3JlY2xrIiwgbWF5IGJlIHByb3ZpZGVkIGlmCj4g PiArCWNvcmUgUExMcyBhcmUgYmFzZWQgb24gYSBkaWZmZXJlbnQgaW5wdXQgY2xvY2sgZnJvbSB0 aGUKPiA+ICsJcGxhdGZvcm0gUExMLgo+ID4gKy0gY2xvY2stbmFtZXM6IFJlcXVpcmVkIGlmIGEg Y29yZWNsayBpcyBwcmVzZW50LsKgwqBWYWxpZCBuYW1lcyBhcmUKPiA+ICsJInN5c2NsayIgYW5k ICJjb3JlY2xrIi4KPiAnY2xrJyBwYXJ0IGlzIHJlZHVuZGFudC4KCiJzeXNjbGsiIGlzIGEgdGVy bSB1c2VkIGJ5IHRoZSBoYXJkd2FyZSBkb2N1bWVudGF0aW9uIGFuZCBJJ2QgcmF0aGVyIGxlYXZl IGl0CmludGFjdC4gwqAiY29yZWNsayIgaXNuJ3QgbmFtZWQgKG9ubHkgZGVzY3JpYmVkKSBieSB0 aGUgaGFyZHdhcmUgZG9jdW1lbnRhdGlvbgpidXQgaXQgaXMgYSBzcGVjaWFsIHZhcmlhbnQgb2Yg c3lzY2xrIGFuZCBoYXZpbmcgc2ltaWxhciBuYW1pbmcgaGVscHMgbWFrZQp0aGF0IGNsZWFyLgoK LVNjb3R0CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=