From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751143AbdA1G0G (ORCPT ); Sat, 28 Jan 2017 01:26:06 -0500 Received: from smtprelay0226.hostedemail.com ([216.40.44.226]:38729 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750762AbdA1GZ5 (ORCPT ); Sat, 28 Jan 2017 01:25:57 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:4321:5007:6737:10004:10400:10848:11026:11232:11658:11914:12043:12048:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: edge73_aad104e56c15 X-Filterd-Recvd-Size: 1698 Message-ID: <1485584071.25660.4.camel@perches.com> Subject: Re: [PATCH] Staging: speakup - syle fix permissions to octal From: Joe Perches To: Derek Robson , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, shraddha.6596@gmail.com, alan@linux.intel.com, shiva@exdev.nl, amitoj1606@gmail.com, amsfield22@gmail.com, bhumirks@gmail.com, waltfeasel@gmail.com Cc: speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 27 Jan 2017 22:14:31 -0800 In-Reply-To: <20170128060509.21260-1-robsonde@gmail.com> References: <20170128060509.21260-1-robsonde@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch [] > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c [] > @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL"); > MODULE_VERSION(SPEAKUP_VERSION); > > char *synth_name; > -module_param_named(synth, synth_name, charp, S_IRUGO); > -module_param_named(quiet, spk_quiet_boot, bool, S_IRUGO); > +module_param_named(synth, synth_name, charp, 0444 ); > +module_param_named(quiet, spk_quiet_boot, bool, 0444 ); Please don't add spaces before the close parenthesis.