From: Jean Delvare <jdelvare@suse.de>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: piix4: Fix request_region size
Date: Sat, 28 Jan 2017 09:36:22 +0100 [thread overview]
Message-ID: <1485592582.4916.1.camel@suse.de> (raw)
In-Reply-To: <20170127145930.13055-1-ricardo.ribalda@gmail.com>
Hi Ricardo,
On ven., 2017-01-27 at 15:59 +0100, Ricardo Ribalda Delgado wrote:
> Since '701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")'
> we
> are using the SMBSLVCNT register at offset 0x8. We need to request
> it.
>
> Fixes: 701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> Please note, not tested on hardware.
> drivers/i2c/busses/i2c-piix4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-
> piix4.c
> index e34d82e79b98..73cc6799cc59 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -58,7 +58,7 @@
> #define SMBSLVDAT (0xC + piix4_smba)
>
> /* count for request_region */
> -#define SMBIOSIZE 8
> +#define SMBIOSIZE 9
>
Are you certain that all supported devices have this extra register?
>
> /* PCI Address Constants */
> #define SMBBA 0x090
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-01-28 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 14:59 [PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado
2017-01-28 8:36 ` Jean Delvare [this message]
2017-01-28 11:00 ` Wolfram Sang
2017-01-28 11:13 ` Jean Delvare
2017-01-30 1:11 ` Ricardo Ribalda Delgado
2017-01-31 13:42 ` Jean Delvare
2017-02-09 16:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485592582.4916.1.camel@suse.de \
--to=jdelvare@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.