Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
Date: Mon, 30 Jan 2017 14:35:29 +0200	[thread overview]
Message-ID: <1485779729.2893.7.camel@linux.intel.com> (raw)
In-Reply-To: <20170130104458.2653-1-chris@chris-wilson.co.uk>

On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> As we add new generations, we should keep detecting new pre-production
> system development platforms that were temporarily enabled to facilitate
> initial development and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
> 
> v2: s/sdv/pre/ - not all system development vehicles are for
> preproduction usage.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

<SNIP>

>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>  {
> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> +	bool pre = false;
> +
> +	pre |= IS_HSW_EARLY_SDV(dev_priv);
> +	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);

Did you compare the asm with "pre = pre || ..."?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx