From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751647AbdAaLSh (ORCPT ); Tue, 31 Jan 2017 06:18:37 -0500 Received: from mout.gmx.net ([212.227.17.21]:50333 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdAaLSc (ORCPT ); Tue, 31 Jan 2017 06:18:32 -0500 Message-ID: <1485861474.4419.3.camel@gmx.de> Subject: Re: WARNING: CPU: 1 PID: 15 at kernel/sched/sched.h:804 assert_clock_updated.isra.62.part.63+0x25/0x27 From: Mike Galbraith To: Ingo Molnar Cc: Matt Fleming , lkml , Peter Zijlstra , Ingo Molnar , Marc Zyngier Date: Tue, 31 Jan 2017 12:17:54 +0100 In-Reply-To: <20170131085455.GB27019@gmail.com> References: <1485588065.4181.7.camel@gmx.de> <20170130115942.GK31613@codeblueprint.co.uk> <1485843569.4423.8.camel@gmx.de> <20170131072839.GA10834@gmail.com> <1485852699.4488.0.camel@gmx.de> <20170131085455.GB27019@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KVx79+ZmjyfWQfpBY9fAU79UOg76hoqfHa7waui+AhS/llkjaEe W7zcTcDOTpPWuTrE+V4+zK9lDallH9AZwEmU1FxD4duhUxh9ST5TNjBlTBpcCYUeCGWp7hy VMU06c1791+LSJJhWiDYmyviOb7IdUuZCoYuhWS1u6j/8Ynz/2dIIIF3Yf5JRIfud/uS7jN YdaEM5hfi7Qz76jfGPVwA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/Y8PhvizXPM=:G/43O3kxTVujMl/s8mEAdV A65X39Raill0r6ByLwKv/v7Iq1lsAc9D6WWcfDLSk66UEMUKngG/WOUWFUtV8AltfC9CN425u vJNfGasnUgW8OHVZsKpD6DQtYvD5ggehzp4xPuWvvI/I5SaxT/rkGi+5prLAOjD9wyttOFBdU okQj1qxISHt3cb4FTZvVPAoncOwNt2C1SThdNP8gyM7TgXHLm4TnVv+WwFpzjsYLdjFd8VwMM r48/QEAeNROmSvk/qYChVjcHanIuDtG1cXB2cu4JyaBhxIZBDYX9vPYuwkvTBDtJUWWHsQW+h Tv/GMIDa8h8Z/PV+WE3vabq4RfRxlutCaf7E05ydC9MdCXT1KCn6mE4sOa8/GcpzwpK6L6TEC rGya3mGmP42QjnvHaIhT4e+F8AF4TRrs4bci/wpd8Dhpp7I7Pha3z6v3EdyPxxrDXJU1sUI0M 8l1xxlTr9ZzQE469uwyijxJoXSncHViuNmDNHJ4gxfubu2et/gM5HZtus0Vgm0nVL9gaL3mlC 9Zp0jPLN0kxAOs7JkadfzjMbCS4s9OE5pR94gMdrlkNNua+PNmTAdF05yuI7MRFqZVtk9l1CT 4ypGNyp78xFzb2zenSZjV7KzPLY66zkVSN/m6+xR0peMPqVWxOxXDriH263kkI6ig20e23/S/ 2PfdNUqelTLaI04Zk9Zv5SCiBoTOUeB3tY5guIoYjoE63HNBHGq88xZ7k7bw3eWcdTdwYMyon 79Vprdv0gmf+Hl1jtGFCJ2AwRhT61/f/CIV0Nlq1CZw8/A2GCUrkmRVi2eFgd6KyoB8UNPeuE Vx19zoyVDGc4x2fxQTZSzjE4jh/9pQ9jwZqjBri1DwdqVx30L3tEhbXQBkzSYsrHrrWBZEUe5 mwLGR5+MszKug6DLJBkDqFjWldKKGCxljhBAc1iKQZkXBxnJfE/O1u6eU5bIDBNn6xg0nNEuO CqhySI8VdHgkO6NGWHEfspxX0SjZTSVTIbF4Wcw7J6mcYbMRPcvO4NZtMgP9ofk+M+IjT4qsN AkLBLsHXld6P3Q2MKMEiEMId01nKrv3Rsywcwpn0/GhzAH8Nx923DXNX5ImDIwcQAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-31 at 09:54 +0100, Ingo Molnar wrote: > > Fast ain't gonna happen, 5bf728f02218 bricked. > > :-/ > > Next point would be f9a42e0d58cf I suspect, to establish that Linus's latest > kernel is fine. That means it's in one of the ~200 -tip commits - should be > bisectable in 8-10 steps from that point on. It bisected cleanly to the below, confirmed via quilt push/pop revert. According to the symptoms my box exhibits, patchlet needs to be twiddled to ensure that interrupts are enabled at _least_ once ;-) 08d85f3ea99f1eeafc4e8507936190e86a16ee8c is the first bad commit commit 08d85f3ea99f1eeafc4e8507936190e86a16ee8c Author: Marc Zyngier Date: Tue Jan 17 16:00:48 2017 +0000 irqdomain: Avoid activating interrupts more than once Since commit f3b0946d629c ("genirq/msi: Make sure PCI MSIs are activated early"), we can end-up activating a PCI/MSI twice (once at allocation time, and once at startup time). This is normally of no consequences, except that there is some HW out there that may misbehave if activate is used more than once (the GICv3 ITS, for example, uses the activate callback to issue the MAPVI command, and the architecture spec says that "If there is an existing mapping for the EventID-DeviceID combination, behavior is UNPREDICTABLE"). While this could be worked around in each individual driver, it may make more sense to tackle the issue at the core level. In order to avoid getting in that situation, let's have a per-interrupt flag to remember if we have already activated that interrupt or not. Fixes: f3b0946d629c ("genirq/msi: Make sure PCI MSIs are activated early") Reported-and-tested-by: Andre Przywara Signed-off-by: Marc Zyngier Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1484668848-24361-1-git-send-email-marc.zyngier@arm.com Signed-off-by: Thomas Gleixner :040000 040000 eed859b1f22b822f4400e7c050929d8b4c4a146d 39097c0315a12c0a3809bb82687fa56b1c9e5633 M include :040000 040000 7dfe2ca8e1de55e890d0e6a761bab9c07c6f5f8a e28a3a54a68866273b474e2053b16155987e06f2 M kernel