From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Tue, 31 Jan 2017 13:24:00 +0000 Subject: stmmac: GMAC_RGSMIIIS reports bogus values In-Reply-To: <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> References: <1478189833.4072.65.camel@synopsys.com> <1485369563.7117.81.camel@synopsys.com> <1485512586.2693.35.camel@synopsys.com> <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> List-ID: Message-ID: <1485869040.2706.15.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi?Giuseppe, On Tue, 2017-01-31@10:55 +0100, Giuseppe CAVALLARO wrote: > On 1/27/2017 11:23 AM, Alexey Brodkin wrote: > > > > That's why my initial proposal was to ignore whatever we read from this register > > if we have MDIO bus instantiated already. > > sorry for my late reply, I agree with this approach, according to the > HW and platform configuration the driver has to understand and then > work to use either SMA or PCS module. I already submitted another solution which IMHO is much cleaner and appropriate, see David has it already in master tree here: http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=0a764db103376cf69d04449b10688f3516cc0b88 -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbdAaN0I (ORCPT ); Tue, 31 Jan 2017 08:26:08 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:52500 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdAaN0A (ORCPT ); Tue, 31 Jan 2017 08:26:00 -0500 From: Alexey Brodkin To: "peppe.cavallaro@st.com" CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: stmmac: GMAC_RGSMIIIS reports bogus values Thread-Topic: stmmac: GMAC_RGSMIIIS reports bogus values Thread-Index: AQHSNe3WHCWZ99cl6060z9b7QcHLU6DYIbIAgHHWYICAApoBAIAGQY8AgAA6TwA= Date: Tue, 31 Jan 2017 13:24:00 +0000 Message-ID: <1485869040.2706.15.camel@synopsys.com> References: <1478189833.4072.65.camel@synopsys.com> <1485369563.7117.81.camel@synopsys.com> <1485512586.2693.35.camel@synopsys.com> <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> In-Reply-To: <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.77] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0VDop83005528 Hi Giuseppe, On Tue, 2017-01-31 at 10:55 +0100, Giuseppe CAVALLARO wrote: > On 1/27/2017 11:23 AM, Alexey Brodkin wrote: > > > > That's why my initial proposal was to ignore whatever we read from this register > > if we have MDIO bus instantiated already. > > sorry for my late reply, I agree with this approach, according to the > HW and platform configuration the driver has to understand and then > work to use either SMA or PCS module. I already submitted another solution which IMHO is much cleaner and appropriate, see David has it already in master tree here: http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=0a764db103376cf69d04449b10688f3516cc0b88 -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: stmmac: GMAC_RGSMIIIS reports bogus values Date: Tue, 31 Jan 2017 13:24:00 +0000 Message-ID: <1485869040.2706.15.camel@synopsys.com> References: <1478189833.4072.65.camel@synopsys.com> <1485369563.7117.81.camel@synopsys.com> <1485512586.2693.35.camel@synopsys.com> <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" To: "peppe.cavallaro@st.com" Return-path: In-Reply-To: <28d0ab2c-eb68-a520-e59a-83b15700fe44@st.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org SGnCoEdpdXNlcHBlLA0KDQpPbiBUdWUsIDIwMTctMDEtMzEgYXQgMTA6NTUgKzAxMDAsIEdpdXNl cHBlIENBVkFMTEFSTyB3cm90ZToNCj4gT24gMS8yNy8yMDE3IDExOjIzIEFNLCBBbGV4ZXkgQnJv ZGtpbiB3cm90ZToNCj4gPiANCj4gPiBUaGF0J3Mgd2h5IG15IGluaXRpYWwgcHJvcG9zYWwgd2Fz IHRvIGlnbm9yZSB3aGF0ZXZlciB3ZSByZWFkIGZyb20gdGhpcyByZWdpc3Rlcg0KPiA+IGlmIHdl IGhhdmUgTURJTyBidXMgaW5zdGFudGlhdGVkIGFscmVhZHkuDQo+IA0KPiBzb3JyeSBmb3IgbXkg bGF0ZSByZXBseSwgSSBhZ3JlZSB3aXRoIHRoaXMgYXBwcm9hY2gsIGFjY29yZGluZyB0byB0aGUN Cj4gSFcgYW5kIHBsYXRmb3JtIGNvbmZpZ3VyYXRpb24gdGhlIGRyaXZlciBoYXMgdG8gdW5kZXJz dGFuZCBhbmQgdGhlbg0KPiB3b3JrIHRvIHVzZSBlaXRoZXIgU01BIG9yIFBDUyBtb2R1bGUuDQoN CkkgYWxyZWFkeSBzdWJtaXR0ZWQgYW5vdGhlciBzb2x1dGlvbiB3aGljaCBJTUhPIGlzIG11Y2gg Y2xlYW5lciBhbmQgYXBwcm9wcmlhdGUsDQpzZWUgRGF2aWQgaGFzIGl0IGFscmVhZHkgaW4gbWFz dGVyIHRyZWUgaGVyZToNCmh0dHA6Ly9naXQua2VybmVsLm9yZy9jZ2l0L2xpbnV4L2tlcm5lbC9n aXQvZGF2ZW0vbmV0LmdpdC9jb21taXQvP2lkPTBhNzY0ZGIxMDMzNzZjZjY5ZDA0NDQ5YjEwNjg4 ZjM1MTZjYzBiODgNCg0KLUFsZXhleQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1zbnBzLWFyYyBtYWlsaW5nIGxpc3QKbGludXgtc25wcy1hcmNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXNucHMtYXJj