From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbdBAVsh (ORCPT ); Wed, 1 Feb 2017 16:48:37 -0500 Received: from smtprelay0232.hostedemail.com ([216.40.44.232]:38097 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750883AbdBAVsg (ORCPT ); Wed, 1 Feb 2017 16:48:36 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3867:3868:3870:3871:4321:4605:4823:5007:6119:7903:9592:10004:10400:10848:11026:11232:11473:11658:11914:12043:12295:12296:12438:12555:12702:12737:12740:12760:12895:12986:13439:14181:14659:14721:21080:21433:21451:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: beast78_67e83a363542b X-Filterd-Recvd-Size: 4624 Message-ID: <1485985712.22276.1.camel@perches.com> Subject: Re: [PATCH] Staging: ks7010: Fix tabs in ks_hostif.h. From: Joe Perches To: Logan Gorence , gregkh@linuxfoundation.org, wsa+renesas@sang-engineering.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 01 Feb 2017 13:48:32 -0800 In-Reply-To: <20170201205928.30651-1-kernelgorence@gmail.com> References: <20170201205928.30651-1-kernelgorence@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-01 at 12:59 -0800, Logan Gorence wrote: > Convert spaces to tabs in ks_hostif.h, according to > the checkpatch.pl script. [] > diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h [] > @@ -569,18 +569,18 @@ struct hostif_mic_failure_confirm_t { > #define TX_RATE_54M (uint8_t)(540/5) > > #define IS_11B_RATE(A) (((A&RATE_MASK)==TX_RATE_1M)||((A&RATE_MASK)==TX_RATE_2M)||\ > - ((A&RATE_MASK)==TX_RATE_5M)||((A&RATE_MASK)==TX_RATE_11M)) > + ((A&RATE_MASK)==TX_RATE_5M)||((A&RATE_MASK)==TX_RATE_11M)) > > #define IS_OFDM_RATE(A) (((A&RATE_MASK)==TX_RATE_6M)||((A&RATE_MASK)==TX_RATE_12M)||\ > - ((A&RATE_MASK)==TX_RATE_24M)||((A&RATE_MASK)==TX_RATE_9M)||\ > - ((A&RATE_MASK)==TX_RATE_18M)||((A&RATE_MASK)==TX_RATE_36M)||\ > - ((A&RATE_MASK)==TX_RATE_48M)||((A&RATE_MASK)==TX_RATE_54M)) > + ((A&RATE_MASK)==TX_RATE_24M)||((A&RATE_MASK)==TX_RATE_9M)||\ > + ((A&RATE_MASK)==TX_RATE_18M)||((A&RATE_MASK)==TX_RATE_36M)||\ > + ((A&RATE_MASK)==TX_RATE_48M)||((A&RATE_MASK)==TX_RATE_54M)) > > #define IS_11BG_RATE(A) (IS_11B_RATE(A)||IS_OFDM_RATE(A)) > > #define IS_OFDM_EXT_RATE(A) (((A&RATE_MASK)==TX_RATE_9M)||((A&RATE_MASK)==TX_RATE_18M)||\ > - ((A&RATE_MASK)==TX_RATE_36M)||((A&RATE_MASK)==TX_RATE_48M)||\ > - ((A&RATE_MASK)==TX_RATE_54M)) > + ((A&RATE_MASK)==TX_RATE_36M)||((A&RATE_MASK)==TX_RATE_48M)||\ > + ((A&RATE_MASK)==TX_RATE_54M)) Rather than just quieting checkpatch messages, please try to make the code more intelligible for humans to read. Doing something like the below is clearer and can actually produce smaller object code too. --- diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index 743f31ead56e..755e53805102 100644 --- a/drivers/staging/ks7010/ks_hostif.h +++ b/drivers/staging/ks7010/ks_hostif.h @@ -568,19 +568,31 @@ struct hostif_mic_failure_confirm_t { #define TX_RATE_48M (uint8_t)(480/5) #define TX_RATE_54M (uint8_t)(540/5) -#define IS_11B_RATE(A) (((A&RATE_MASK)==TX_RATE_1M)||((A&RATE_MASK)==TX_RATE_2M)||\ - ((A&RATE_MASK)==TX_RATE_5M)||((A&RATE_MASK)==TX_RATE_11M)) - -#define IS_OFDM_RATE(A) (((A&RATE_MASK)==TX_RATE_6M)||((A&RATE_MASK)==TX_RATE_12M)||\ - ((A&RATE_MASK)==TX_RATE_24M)||((A&RATE_MASK)==TX_RATE_9M)||\ - ((A&RATE_MASK)==TX_RATE_18M)||((A&RATE_MASK)==TX_RATE_36M)||\ - ((A&RATE_MASK)==TX_RATE_48M)||((A&RATE_MASK)==TX_RATE_54M)) - -#define IS_11BG_RATE(A) (IS_11B_RATE(A)||IS_OFDM_RATE(A)) - -#define IS_OFDM_EXT_RATE(A) (((A&RATE_MASK)==TX_RATE_9M)||((A&RATE_MASK)==TX_RATE_18M)||\ - ((A&RATE_MASK)==TX_RATE_36M)||((A&RATE_MASK)==TX_RATE_48M)||\ - ((A&RATE_MASK)==TX_RATE_54M)) +#define IS_11B_RATE(A) \ +({ \ + typeof(A) _r = (A) & RATE_MASK; \ + (_r == TX_RATE_1M || _r == TX_RATE_2M || \ + _r == TX_RATE_5M || _r == TX_RATE_11M); \ +}) + +#define IS_OFDM_RATE(A) \ +({ \ + typeof(A) _r = (A) & RATE_MASK; \ + (_r == TX_RATE_6M || _r == TX_RATE_12M || \ + _r == TX_RATE_24M || _r == TX_RATE_9M || \ + _r == TX_RATE_18M || _r == TX_RATE_36M || \ + _r == TX_RATE_48M || _r == TX_RATE_54M); \ +}) + +#define IS_11BG_RATE(A) (IS_11B_RATE(A) || IS_OFDM_RATE(A)) + +#define IS_OFDM_EXT_RATE(A) \ +({ \ + typeof(A) _r = (A) & RATE_MASK; \ + (_r == TX_RATE_9M || _r == TX_RATE_18M || \ + _r == TX_RATE_36M || _r == TX_RATE_48M || \ + _r == TX_RATE_54M); \ +}) enum { CONNECT_STATUS = 0,