Re: [Qemu-devel] [PULL 4/4] cirrus: fix oob access issue (CVE-2017-2615)

[Gerd Hoffmann <kraxel@redhat.com>]

> > Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > Message-id: 1485938101-26602-1-git-send-email-kraxel@redhat.com
> > Message-id: 5887254f.863a240a.2c122.5500@mx.google.com
> > 
> > { kraxel: with backward blits (negative pitch) addr is the topmost
> >           address, so check it as-is against vram size ]
> > 
> > Cc: qemu-stable@nongnu.org
> > Cc: P J P <ppandit@redhat.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
> > Fixes: d3532a0db02296e687711b8cdc7791924efccea0 (CVE-2014-8106)
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

> My inner pedant wishes to observe that my review concerned the patch as
> modified by you, so for complete accuracy, my R-b should be at the
> bottom, under your S-o-b.
> 
> Not sure if this merits a PULLv2, I just needed to "silence to voices".

Oops.  The message ids are kinda f*cked up too.  Guess I shouldn't trust
the patches tool too much when it comes to non-trivial patch flows.

I'll respin the pull request.

cheers,
  Gerd