From: Joe Perches <joe@perches.com>
To: Martin Karamihov <martinowar@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)
Date: Thu, 02 Feb 2017 15:32:56 -0800 [thread overview]
Message-ID: <1486078376.22276.54.camel@perches.com> (raw)
In-Reply-To: <2933ae60-bc8a-278e-b81e-03924de72182@gmail.com>
On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote:
> On 02/01/2017 08:11 PM, Joe Perches wrote:
> > ...and clarifying the code for a
> > human reader is much more important than making a
> > file not have any checkpatch warnings.
>
> I agree. I respect the developers' own coding style and believe that
> some things (>80 characters long lines, name conventions, etc) should be
> fixed by themselves (if they want to do that). I selected several TODOs
> with requests for code cleanups and chose a fix in attempt to accomplish
> my task with minimal inconvenience for the maintainers. I failed in my
> first attempts breaking some basic rules, sorry about that.
No, not at all. You did fine for a basic checkpatch cleanup.
I just wanted to tell you to think beyond checkpatch.
cheers, Joe
prev parent reply other threads:[~2017-02-02 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 8:49 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
2017-01-28 9:11 ` Greg KH
2017-01-29 16:43 ` Bjørn Mork
2017-01-29 18:57 ` martinowar
2017-02-02 22:53 ` Joe Perches
2017-01-31 19:24 ` [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix) Martin Karamihov
2017-01-31 22:39 ` Joe Perches
2017-02-01 16:36 ` Martin Karamihov
2017-02-01 18:11 ` Joe Perches
2017-02-02 6:06 ` Martin Karamihov
2017-02-02 23:32 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486078376.22276.54.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martinowar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.