From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/igt_kmod: Compare module names with strcmp
Date: Fri, 03 Feb 2017 12:44:22 +0200 [thread overview]
Message-ID: <1486118662.5555.2.camel@gmail.com> (raw)
In-Reply-To: <20170203102409.GJ17696@nuc-i3427.alporthouse.com>
On Fri, 2017-02-03 at 10:24 +0000, Chris Wilson wrote:
> On Fri, Feb 03, 2017 at 12:09:46PM +0200, Ander Conselvan de Oliveira wrote:
> > The function igt_kmod_is_loaded() returns the wrong value when there is
> > a module loaded whose name is a prefix of the name supplied as a
> > paremter. For instance, if the "snd" module is loaded,
> > igt_kmod_is_load("snd_hda_intel") will return true even if that module
> > isn't loaded, thus causing drv_module_reload to failure in that
> > scenario.
>
> Ah, that would explain some of the mystery.
>
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@inte
> > l.com>
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks. Pushed with commit message typos fixed.
Ander
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-02-03 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 10:09 [PATCH i-g-t] lib/igt_kmod: Compare module names with strcmp Ander Conselvan de Oliveira
2017-02-03 10:24 ` Chris Wilson
2017-02-03 10:44 ` Ander Conselvan De Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486118662.5555.2.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.