From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel =?ISO-8859-1?Q?Sch=F6lling?= Date: Fri, 03 Feb 2017 16:04:15 +0000 Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Message-Id: <1486137855.17160.19.camel@gmx.de> List-Id: References: <4640722.jsFVORW8WM@amdc3058> <20170110212838.16175-1-manuel.schoelling@gmx.de> <20170110212838.16175-5-manuel.schoelling@gmx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Paul Gortmaker Cc: "gregkh@linuxfoundation.org" , jslaby@suse.com, kilobyte@angband.pl, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, Andrew Morton , paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, LKML , linux-fbdev@vger.kernel.org Hi Paul, On Thu, 2017-02-02 at 15:07 -0500, Paul Gortmaker wrote: > On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling > wrote: > > The impact of the persistent scrollback feature on the code size is > > rather small, so the config option is removed. The feature stays > > disabled by default and can be enabled by using the boot command > > line > > parameter 'vgacon.scrollback_persistent=1' or by setting > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > Signed-off-by: Manuel Schölling > > Suggested-by: Bartlomiej Zolnierkiewicz > > --- > > [...] > > > +module_param_named(scrollback_persistent, scrollback_persistent, > > bool, 0000); > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > scrollback for all vga consoles"); > > Since this hasn't got widespread deployment yet and  only exists > in Greg's tree, can we please fix the above to use setup_param or > similar, since there is nothing modular about this code at all. Not sure what you mean here. If this is not the right may to declare it I'd be more than happy to change this. But I could not find any function/macro named setup_param [1]. It would be great if you could give me a hint what function to use here! Have a great weekend! Manuel [1] http://lxr.free-electrons.com/ident?i=setup_param From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbdBCQGL convert rfc822-to-8bit (ORCPT ); Fri, 3 Feb 2017 11:06:11 -0500 Received: from mout.gmx.net ([212.227.15.19]:61923 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbdBCQGJ (ORCPT ); Fri, 3 Feb 2017 11:06:09 -0500 Message-ID: <1486137855.17160.19.camel@gmx.de> Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter From: Manuel =?ISO-8859-1?Q?Sch=F6lling?= To: Paul Gortmaker Cc: "gregkh@linuxfoundation.org" , jslaby@suse.com, kilobyte@angband.pl, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, Andrew Morton , paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, LKML , linux-fbdev@vger.kernel.org Date: Fri, 03 Feb 2017 17:04:15 +0100 In-Reply-To: References: <4640722.jsFVORW8WM@amdc3058> <20170110212838.16175-1-manuel.schoelling@gmx.de> <20170110212838.16175-5-manuel.schoelling@gmx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:+rBPXNQfoJm5cTI5OWdCvjofhvYM62lblm8jMCO4REV4GPBJALY SDFQ7mzB377O3wKU+zPMo8WtzBUsy+y4fP/cTmTSFJ8wb6pr24mCRxRO6y80wvIHPK9Q1ry rfGSOX1HuW0zpTmiPN3897oKGu28jivVumfKAFInwZ2MFo9JogI0Z6ORmzCAiEqDoD23jPG 1iJwXMHGjWrbPPUIthguA== X-UI-Out-Filterresults: notjunk:1;V01:K0:0QNPmCaECjI=:CN4AthAz57MjBsrR2ruWqp 6bSN6rEeMHe4h2XNyO/Q0eIGchvwsVw7WQmIZIMndv/PAoNx1/8B0m5F0BbUdDTZqGdoXyiVo 0V+0lBB8cftDe50m45O4hY4kpdlWW+R1DJda4dKpqu6MRbg7RqlGX9LvMmCCuSMYIsu0M52BT gphSGQimC7Op/oB/SGr1UciSmiHPMXOOwHtLQimbEeyZVlLZGb0i1q7mwyJopiM1RX6oUFndj Eqdwwi0CXoVcD3lRzGjzooZZoO7aqC0JL3iM49Le+BMXx+kBZf9AHXadKTgY1DbjrEF9AtVXp saJwRFqW6kk1Aj/4LXmHOUF117xavYCV1GGhhOE1ozecnC9i8PpTG7MXqnxj6xBUbqWrB35qk 7a58X58yqAWJMq+p76kKULGmGEEbWK+6DAExaoCvU86AZcKf3RibIPs2xGqowR1CCtu2rNV4W XgNF3I83I4Ism9TuvAymaFErTFX3ROBVX5oMJtNGCnkSW2wG6hysoD7WkpDmorktfcmlPSqYI OBCU7U7s+dFVNUAfv5/BxpiceRzc/0lD5Ly/w8iaQtQNblPd2kd8DaOYTEuN4Hpi6Ud5zeO0u Kcj+KqSTItsgT7UNGKykcELj4fC7pHLFJjLD3jksilDHtkzPHp0PMXwPIWWzDUBbPkb96s6j0 ATN35SEZX3judnwNKlfGjwzPjtUFU06IqUhNSyX7+v3ocT2QkOngSaJMnFw5l7RoN8nJp5j6h aEO2Ph9Lq+iOX7GbIyU5YW81IdzJGw9T9FnaRiSwSxcfdWnxoEyTxkTO7s7r3imTDoUHoCGYW xHeku8b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Thu, 2017-02-02 at 15:07 -0500, Paul Gortmaker wrote: > On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling > wrote: > > The impact of the persistent scrollback feature on the code size is > > rather small, so the config option is removed. The feature stays > > disabled by default and can be enabled by using the boot command > > line > > parameter 'vgacon.scrollback_persistent=1' or by setting > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > Signed-off-by: Manuel Schölling > > Suggested-by: Bartlomiej Zolnierkiewicz > > --- > > [...] > > > +module_param_named(scrollback_persistent, scrollback_persistent, > > bool, 0000); > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > scrollback for all vga consoles"); > > Since this hasn't got widespread deployment yet and  only exists > in Greg's tree, can we please fix the above to use setup_param or > similar, since there is nothing modular about this code at all. Not sure what you mean here. If this is not the right may to declare it I'd be more than happy to change this. But I could not find any function/macro named setup_param [1]. It would be great if you could give me a hint what function to use here! Have a great weekend! Manuel [1] http://lxr.free-electrons.com/ident?i=setup_param