From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932098AbdBFOue (ORCPT ); Mon, 6 Feb 2017 09:50:34 -0500 Received: from smtprelay0176.hostedemail.com ([216.40.44.176]:38933 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752242AbdBFOuc (ORCPT ); Mon, 6 Feb 2017 09:50:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:7875:10004:10400:10848:11232:11658:11914:12294:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:14721:21080:30012:30054:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crow69_5bb9268bcb855 X-Filterd-Recvd-Size: 2197 Message-ID: <1486392629.3616.4.camel@perches.com> Subject: Re: [PATCH v3] staging: lustre: align else if statement to coding standard From: Joe Perches To: Greg Kroah-Hartman , Maksymilian Piechota Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Mon, 06 Feb 2017 06:50:29 -0800 In-Reply-To: <20170206130359.GB5504@kroah.com> References: <20170206122652.GA19889@maks-debian.localdomain> <20170206125002.GA4409@kroah.com> <20170206125638.GA20310@maks-debian.localdomain> <20170206130359.GB5504@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote: > > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote: > > > > - move logical continuations at the end of line > > > > - move else if statement to a single line > > > > - Replace spaces with tabstop. > > > > > > That's a lot of different things, happening all at once. Please break > > > this up into multiple patches, each one only doing one thing, and send a > > > patch series. > > > > > > thanks, > > > > > > greg k-h > > > > Fixing two lines of code in three patches? > > Yes. Greg is also sometimes completely crazy. I think he's only doing this because you are a relatively new patch submitter and he wants you to go through some linux-kernel process hazing. It'd be more efficient as a single patch and better overall to avoid descriptions with multiple characteristics that elicit Greg's somewhat OCD reflexes. If this commit log was merely described as "use a normal kernel style" for the else if and nothing else was mentioned, this would likely have been accepted.