From: Josef Bacik <jbacik@fb.com>
To: <linux-block@vger.kernel.org>, <kernel-team@fb.com>,
<nbd-general@lists.sourceforge.net>, <axboe@kernel.dk>
Subject: Re: [PATCH] nbd: freeze the queue before making changes
Date: Tue, 7 Feb 2017 11:36:32 -0500 [thread overview]
Message-ID: <1486485392.4094.0.camel@fb.com> (raw)
In-Reply-To: <1486396489-2911-1-git-send-email-jbacik@fb.com>
On Mon, 2017-02-06 at 10:54 -0500, Josef Bacik wrote:
> The way we make changes to the NBD device is inherently racey, as we
> could be in the middle of a request and suddenly change the number of
> connections. In practice this isn't a big deal, but with timeouts we
> have to take the config_lock in order to protect ourselves since it
> is
> important those values don't change. Fix this by freezing the queue
> before we do any of our device operations.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Actually nevermind, this messes with my plans around reconnections
since freezing also waits for existing timeouts to fire. I'll drop
this and fix it a different way. Thanks,
Josef
prev parent reply other threads:[~2017-02-07 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 15:54 [PATCH] nbd: freeze the queue before making changes Josef Bacik
2017-02-07 16:36 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486485392.4094.0.camel@fb.com \
--to=jbacik@fb.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.